Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling perf regression in Complex Layout benchmark #7407

Closed
yjbanov opened this issue Jan 10, 2017 · 5 comments
Closed

Scrolling perf regression in Complex Layout benchmark #7407

yjbanov opened this issue Jan 10, 2017 · 5 comments
Assignees
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Jan 10, 2017

The complex layout benchmark seems to show a performance regression in the Tabs API change. It is mostly visible in worst frame build times and missed rasterizer (GPU) frame counts.

Steps to Reproduce

cd dev/devicelab
dart bin/run.dart -t bin/tasks/complex_layout_scroll_perf__timeline_summary.dart

Logs

complex-layout-tab-api-regression

@yjbanov yjbanov added the c: performance Relates to speed or footprint issues (see "perf:" labels) label Jan 10, 2017
@eseidelGoogle eseidelGoogle added the c: regression It was better in the past than it is now label Jan 10, 2017
@Hixie
Copy link
Contributor

Hixie commented Jan 27, 2017

@HansMuller Looking at this, my first step towards debugging it would be to run the benchmarks under the profiler immediately before the suspect patch and immediately after the suspect patch to see what the difference is.

@HansMuller
Copy link
Contributor

I was able to confirm the problem and that it was introduced by #7387. Since then the benchmark's performance has returned to normal.

It would be useful to sort out what caused the regression however at the moment #7763 makes it difficult to profile the benchmark.

@Hixie
Copy link
Contributor

Hixie commented Feb 27, 2017

@HansMuller #7763 is obsolete now, so this should be testable again.

@Hixie Hixie added this to the No milestone necessary milestone Feb 28, 2017
@yjbanov
Copy link
Contributor Author

yjbanov commented Dec 6, 2017

This has improved greatly since the issue was filed. Closing.

@yjbanov yjbanov closed this as completed Dec 6, 2017
@github-actions
Copy link

github-actions bot commented Aug 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: performance Relates to speed or footprint issues (see "perf:" labels) c: regression It was better in the past than it is now
Projects
None yet
Development

No branches or pull requests

4 participants