Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for setting devtools URL after a hot restart #74442

Open
jonahwilliams opened this issue Jan 21, 2021 · 1 comment
Open

Add test case for setting devtools URL after a hot restart #74442

jonahwilliams opened this issue Jan 21, 2021 · 1 comment
Labels
P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
Tools - DevTools review

Comments

@jonahwilliams
Copy link
Member

This was fixed in 75dc45a , different error then the crash. It was discovered that the tester device hot restart was not behaving correctly.

Explore what was causing the tester issue and/or add a unit test case instead
@jonahwilliams jonahwilliams added tool Affects the "flutter" command-line tool. See also t: labels. P2 Important issues not at the top of the work list labels Jan 21, 2021
@jonahwilliams jonahwilliams mentioned this issue Jan 21, 2021
Closed
@Hixie
Copy link
Contributor

Hixie commented Jan 21, 2021

This failing was considered a P0. We should treat not having a test for it as part of that P0.

@jmagman jmagman added this to Awaiting triage in Tools - DevTools review via automation Jan 21, 2021
@darshankawar darshankawar mentioned this issue Jan 26, 2021
Closed
@pedromassangocode pedromassangocode mentioned this issue Mar 8, 2021
Open
@flutter-triage-bot flutter-triage-bot bot added team-tool Owned by Flutter Tool team triaged-tool Triaged by Flutter Tool team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important issues not at the top of the work list team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels. triaged-tool Triaged by Flutter Tool team
Projects
Tools - DevTools review
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hixie @jonahwilliams @pedromassangocode