Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to update FlutterPlugin.groovy #7504

Closed
abarth opened this issue Jan 16, 2017 · 4 comments
Closed

Should be able to update FlutterPlugin.groovy #7504

abarth opened this issue Jan 16, 2017 · 4 comments
Assignees
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@abarth
Copy link
Contributor

abarth commented Jan 16, 2017

In gradle-based builds, we have a FlutterPlugin.groovy in the user's source tree. As we iterate in the build system, we're likely to want to change this plugin. We need a mechanism for updating the copy of this file in the user's source tree when we change the version in our source tree.

The simplest thing is to check whether the version in the user's source tree is byte-identical (or has a matching hash) with the version flutter_tools expects.

@abarth abarth added tool Affects the "flutter" command-line tool. See also t: labels. platform-android Android applications specifically labels Jan 16, 2017
@abarth
Copy link
Contributor Author

abarth commented Jan 24, 2017

Someone just hit this issue in gitter.

@eseidelGoogle
Copy link
Contributor

Is this now resolved with @jakobr-google's work?

@abarth
Copy link
Contributor Author

abarth commented Feb 9, 2017

Yes. It will be resolved once #7902 lands.

@jakobr-google jakobr-google self-assigned this Feb 10, 2017
@jakobr-google jakobr-google moved this from TODO to Done in Make gradle build great! Feb 10, 2017
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Development

No branches or pull requests

3 participants