Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stocks app everything is awesome checkbox changes without waiting for validation from the popup when you touch it directly #75

Closed
FlutterIssues opened this issue Nov 9, 2015 · 6 comments
Labels
framework flutter/packages/flutter repository. See also f: labels.

Comments

@FlutterIssues
Copy link

Issue by Hixie
Thursday Jul 16, 2015 at 22:27 GMT
Originally opened as https://github.com/flutter/engine/issues/33


From @iansf on July 7, 2015 22:21

Touching the "Everything is awesome" text correctly waits for validation from the popup, though.

Copied from original issue: domokit/mojo#305

@FlutterIssues FlutterIssues added bug framework flutter/packages/flutter repository. See also f: labels. labels Nov 9, 2015
@FlutterIssues
Copy link
Author

Comment by collinjackson
Monday Aug 10, 2015 at 17:46 GMT


I believe that this will get easier once we have the gesture recognizers that can negotiate for ownership over the tap event.

@FlutterIssues
Copy link
Author

Comment by eseidelGoogle
Monday Aug 24, 2015 at 21:43 GMT


I think this is the same as https://github.com/domokit/sky_engine/issues/42 Can we close one of them?

@sethladd
Copy link
Contributor

sethladd commented Dec 8, 2015

There's no prompt when you disable "everything is awesome", but there is a prompt when you enable "everything is awesome".

Should there be a prompt when you disable/uncheck?

If not, we can probably close this.

@Hixie
Copy link
Contributor

Hixie commented Dec 9, 2015

Does it act any differently if you tap the checkbox directly vs tapping the text?

@Hixie
Copy link
Contributor

Hixie commented Dec 9, 2015

Just tested it, and yeah, it looks like it's working well now.

@Hixie Hixie closed this as completed Dec 9, 2015
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

No branches or pull requests

3 participants