Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine -> Framework roller is blocked on unnecessary_imports lint. #82844

Closed
zanderso opened this issue May 18, 2021 · 3 comments
Closed

Engine -> Framework roller is blocked on unnecessary_imports lint. #82844

zanderso opened this issue May 18, 2021 · 3 comments
Labels
dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression

Comments

@zanderso
Copy link
Member

Starting with the roll attempt here: #82778, from the Dart roll here: flutter/engine#26212, and the Dart commit here: https://dart.googlesource.com/sdk.git/+/2bcc415510abf73e8d8b993625b5c3a0f9c8476d.

The failing presubmit checks on that roll attempt indicate the places that need to be updated.

/cc @jason-simmons @devoncarew @srawlins @chinmaygarde
@zanderso zanderso added dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression labels May 18, 2021
@zanderso zanderso mentioned this issue May 18, 2021
Merged
@zanderso
Copy link
Member Author

Revert of the Dart SDK lint is here: https://dart-review.googlesource.com/c/sdk/+/200521

@zanderso
Copy link
Member Author

The roller is moving again.

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jun 10, 2021
@srawlins
Remove unnecessary import from analyzer/test
38a729a 
flutter/flutter#82844

Change-Id: I0202162487a35c4b190f82d361bce8f67241d53b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203290
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
@github-actions
Copy link

github-actions bot commented Aug 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zanderso