[Widget test] Tapping DropdownMenuItem fails hit test #82908
Labels
a: quality
A truly polished experience
a: tests
"flutter test", flutter_test, or one of our tests
f: material design
flutter/packages/flutter/material repository.
found in release: 2.2
Found to occur in 2.2
framework
flutter/packages/flutter repository. See also f: labels.
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
P2
Important issues not at the top of the work list
team-design
Owned by Design Languages team
triaged-design
Triaged by Design Languages team
Comments
|
@Tregan |
darshankawar
added
the
waiting for customer response
|
@darshankawar This is included in the flutter_test package (Flutter 2.2.0) and makes it so that any hit test failures during tests fail the test, instead of just printing the warning. |
no-response
bot
removed
the
waiting for customer response
|
Ah. Thanks. I was on 2.0.6 on which it gives that error. Running the test fails with below log: console error logflutter doctor -v |
darshankawar
added
a: tests
|
I have a lot of false positives for hit test failures after 2.2.0 upgrade, in Dropdowns, in Dialogs and in TextInputs. |
|
This is still the case in Flutter 2.5.0 (stable) as well as master (2.6.0), even after these fixes: #80856 #86449 Logsflutter doctor -v |
|
Trying to hit the text of options in a PopupMenuButton also gets flagged with the warnIfMissed warning sometimes. |
|
It's weird, this isn't always reliably a problem. For example, the first case below passes, but the second fails: import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
WidgetController.hitTestWarningShouldBeFatal = true;
testWidgets('Clicking DropdownMenuItem should not fail', (WidgetTester tester) async {
await tester.pumpWidget(MaterialApp(
home: Center(
child: Material(
child: DropdownButton<int>(
key: Key('button'),
onChanged: (int? result) { },
items: <DropdownMenuItem<int>>[
const DropdownMenuItem<int>(
key: Key('item'),
value: 1,
child: Text('111111111111111111'),
),
],
),
),
),
));
await tester.tap(find.byKey(Key('button')));
await tester.pump();
await tester.pump(const Duration(seconds: 1));
await tester.tap(find.byKey(Key('item')).at(1));
});
testWidgets('Clicking DropdownMenuItem should not fail', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Center(
child: Material(
child: DropdownButton<int>(
onChanged: (int? value) { },
key: Key('button'),
items: <DropdownMenuItem<int>>[
DropdownMenuItem(
key: Key('item'),
value: 1,
child: Text('1'),
),
],
),
),
),
),
);
await tester.tap(find.byKey(Key('button')));
await tester.pump();
await tester.pump(const Duration(seconds: 1));
await tester.tap(find.byKey(Key('item')).at(1));
});
}(I believe the only difference is the length of the text.) |
|
Still seeing this, and yes, it seems like the length of the text matters. In my test case it failed with the text 'Foo' but passed with 'FooFoo'. |
|
I decided to check this again, and the issue seems to have been fixed. |
flutter-triage-bot
bot
added
multiteam-retriage-candidate
team-design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to Reproduce
widget_test.darttoExpected results:
The test is expected to succeed without any warnings or errors being thrown around
Actual results:
The test fails because the hit test for the line
await tester.tap(find.byKey(Key('2')));fails.Logs
The text was updated successfully, but these errors were encountered: