Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86449

dkwingsmt · 2021-07-14T22:20:55Z

This PR fixes several bugs related to live tests, adds more tests, and completes the documentation of several methods related to pointer events. More specifically:

The several tests for LiveTestWidgetsFlutterBinding added by #83337 were discovered by #82712 (comment) to fail when setSurfaceSize is called. This PR fixed these problems and added a setSurfaceSize version for these tests.

This PR fixes few problems of live tests:

[codelab][flutter_app_testing] Widget test fails when run on device #82542 reported that simulated pointer events do not work on live tests (for example, some code lab tests are broken).
Tapping the screen on live tests should print the hit widgets, instead the events are currently forwarded to the app and painted.
The painted event positions currently do not match the positions where the user interact.

This PR changed the testing widget used in animation/live_binding_test.dart. The target widget is now an InkWell to clearly ensure that the hitTest occurs at the intended local position.

Finally, this PR updated some documentations for some methods, most importantly, whether a pointer event should be in the global coordinate system or the local one.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

skia-gold · 2021-07-14T22:29:19Z

Gold has detected about 3 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/86449

skia-gold · 2021-07-15T10:39:19Z

Gold has detected about 6 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/86449

skia-gold · 2021-07-15T11:34:19Z

Gold has detected about 4 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/86449

skia-gold · 2021-07-16T00:59:19Z

Gold has detected about 2 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/86449

skia-gold · 2021-07-16T01:44:19Z

Gold has detected about 4 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/86449

skia-gold · 2021-07-16T06:34:19Z

Gold has detected about 3 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/86449

flutter-dashboard · 2021-07-16T06:59:53Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86449 at sha b3a4553bcbf9969b44756019a345717b72900693

Fix codelab works Doc and print Fix tests

flutter-dashboard · 2021-07-16T08:24:52Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86449 at sha 559b13a

goderbauer

Thanks so much for debugging this!

packages/flutter_test/lib/src/binding.dart

packages/flutter_test/lib/src/widget_tester.dart

flutter-dashboard · 2021-07-19T06:49:41Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86449 at sha f40be96

goderbauer

LGTM

goderbauer · 2021-07-19T16:24:00Z

packages/flutter_test/lib/src/binding.dart

+///  * The _global coordinate space_ is the one used by the device.
+///
+/// Positions can be transformed between coordinate spaces with [localToGlobal]
+/// and [globalToLocal].


Nice explanation! 👍

Maybe add a note that global and local coordinate space are usually identically when run in the headless flutter_tester.

Really? I thought they are still 800x600 and 2400x1800 respectively, which still require transforming. Also I worry if that comment suggests people don't need to worry about transforming in normal cases - they always should!

Ok, let's leave the comment as is.

flutter-dashboard · 2021-07-19T21:39:41Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86449 at sha 8219ea8

zanderso · 2021-07-20T17:22:34Z

It looks like some issue with the goldens precipitated by this change is affecting rolls from Engine and Plugins:

See:
#86687
#86690

Piinks · 2021-07-20T17:57:16Z

@dkwingsmt please triage images before manually merging PRs. They end up causing errant golden file failures for other PRs.

Is it possible that this change causes an inconsistent image? It look like it has been different for each commit following this change, although it could be caused by the untriaged image errors. They appear to be triaged now, so if they continue to vary for every commit there may be something wrong with the test.

…nd live tests (#86449)" This reverts commit cd78190.

…nd live tests (#86449)" (#86730) This reverts commit cd78190.

…ceSize and live tests (flutter#86449)" (flutter#86730)" This reverts commit 8802e32.

…ceSize and live tests (flutter#86449)" (flutter#86730)" This reverts commit 8802e32. Fix pointer Trigger Build Change test to gesture detector

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 14, 2021

dkwingsmt marked this pull request as draft July 14, 2021 22:21

google-cla bot added the cla: yes label Jul 14, 2021

goderbauer mentioned this pull request Jul 14, 2021

[flutter_test/integration_test] added setSurfaceSize test coverage #82712

Merged

8 tasks

dkwingsmt changed the title ~~Cover setSurfaceSize for live widget test binding~~ Refine tests and docs related to LiveTestWidgetsFlutterBinding Jul 16, 2021

dkwingsmt changed the title ~~Refine tests and docs related to LiveTestWidgetsFlutterBinding~~ Make LiveTestWidgetsFlutterBinding work with setSurfaceSize Jul 16, 2021

dkwingsmt changed the title ~~Make LiveTestWidgetsFlutterBinding work with setSurfaceSize~~ Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests Jul 16, 2021

dkwingsmt marked this pull request as ready for review July 16, 2021 01:35

dkwingsmt mentioned this pull request Jul 16, 2021

[codelab][flutter_app_testing] Widget test fails when run on device #82542

Closed

dkwingsmt requested a review from goderbauer July 16, 2021 01:39

flutter-dashboard bot added the will affect goldens Changes to golden files label Jul 16, 2021

Add setSurfaceSize changes

559b13a

Fix codelab works Doc and print Fix tests

dkwingsmt force-pushed the set-surface-size-test-messages branch from b3a4553 to 559b13a Compare July 16, 2021 07:55

goderbauer reviewed Jul 16, 2021

View reviewed changes

Review

f40be96

dkwingsmt requested a review from goderbauer July 19, 2021 06:21

goderbauer approved these changes Jul 19, 2021

View reviewed changes

Typo

8219ea8

dkwingsmt merged commit cd78190 into flutter:master Jul 19, 2021

dkwingsmt deleted the set-surface-size-test-messages branch July 19, 2021 21:54

Piinks added a commit that referenced this pull request Jul 20, 2021

Revert "Make LiveTestWidgetsFlutterBinding work with setSurfaceSize a…

289f4f6

…nd live tests (#86449)" This reverts commit cd78190.

Piinks mentioned this pull request Jul 20, 2021

Revert "Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests" #86730

Merged

Piinks added a commit that referenced this pull request Jul 20, 2021

Revert "Make LiveTestWidgetsFlutterBinding work with setSurfaceSize a…

8802e32

…nd live tests (#86449)" (#86730) This reverts commit cd78190.

dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Jul 20, 2021

Revert "Revert "Make LiveTestWidgetsFlutterBinding work with setSurfa…

74e5211

…ceSize and live tests (flutter#86449)" (flutter#86730)" This reverts commit 8802e32.

dkwingsmt mentioned this pull request Jul 20, 2021

Reland: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86739

Merged

8 tasks

This was referenced Jul 22, 2021

Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86912

Merged

Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #87239

Merged

nt4f04uNd mentioned this pull request Aug 15, 2021

tester should be allowed to make gestures with flutter run #78749

Closed

Tregan mentioned this pull request Sep 10, 2021

[Widget test] Tapping DropdownMenuItem fails hit test #82908

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86449

Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86449

dkwingsmt commented Jul 14, 2021 •

edited

skia-gold commented Jul 14, 2021

skia-gold commented Jul 15, 2021

skia-gold commented Jul 15, 2021

skia-gold commented Jul 16, 2021

skia-gold commented Jul 16, 2021

skia-gold commented Jul 16, 2021

flutter-dashboard bot commented Jul 16, 2021

flutter-dashboard bot commented Jul 16, 2021

goderbauer left a comment

flutter-dashboard bot commented Jul 19, 2021

goderbauer left a comment

goderbauer Jul 19, 2021

goderbauer Jul 19, 2021

dkwingsmt Jul 19, 2021 •

edited

goderbauer Jul 19, 2021

flutter-dashboard bot commented Jul 19, 2021

zanderso commented Jul 20, 2021

Piinks commented Jul 20, 2021

Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86449

Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86449

Conversation

dkwingsmt commented Jul 14, 2021 • edited

Pre-launch Checklist

skia-gold commented Jul 14, 2021

skia-gold commented Jul 15, 2021

skia-gold commented Jul 15, 2021

skia-gold commented Jul 16, 2021

skia-gold commented Jul 16, 2021

skia-gold commented Jul 16, 2021

flutter-dashboard bot commented Jul 16, 2021

flutter-dashboard bot commented Jul 16, 2021

goderbauer left a comment

Choose a reason for hiding this comment

flutter-dashboard bot commented Jul 19, 2021

goderbauer left a comment

Choose a reason for hiding this comment

goderbauer Jul 19, 2021

Choose a reason for hiding this comment

goderbauer Jul 19, 2021

Choose a reason for hiding this comment

dkwingsmt Jul 19, 2021 • edited

Choose a reason for hiding this comment

goderbauer Jul 19, 2021

Choose a reason for hiding this comment

flutter-dashboard bot commented Jul 19, 2021

zanderso commented Jul 20, 2021

Piinks commented Jul 20, 2021

dkwingsmt commented Jul 14, 2021 •

edited

dkwingsmt Jul 19, 2021 •

edited