Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presubmits are failing with HTTP 400 on dart.googlesource.com repos. #86326

Closed
chinmaygarde opened this issue Jul 12, 2021 · 5 comments
Closed

Presubmits are failing with HTTP 400 on dart.googlesource.com repos. #86326

chinmaygarde opened this issue Jul 12, 2021 · 5 comments
Assignees
@yusufm
Labels
dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team
Projects
Infra Ticket Queue

Comments

@chinmaygarde
Copy link
Member

There are numerous instances of these failures.

Some are able to reproduce this locally. I could not do so on my Mac host from home.

Logs are:

src/third_party/dart/third_party/pkg_tested/dart_style (ERROR)
----------------------------------------
[0:01:44] Started.
[0:01:44] 

________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/dart_style.git /tmp/clean_engine/src/third_party/dart/third_party/pkg_tested/_gclient_dart_style_58vpkdez' in '/tmp/clean_engine'

[0:01:44] Cloning into '/tmp/clean_engine/src/third_party/dart/third_party/pkg_tested/_gclient_dart_style_58vpkdez'...
[0:01:44] remote: Counting objects: 1           
[0:01:44] remote: Counting objects: 84, done        
[0:01:44] Receiving objects:   0% (1/7305)   
[0:01:44] Receiving objects:  10% (731/7305)   
[0:01:45] Receiving objects:  60% (4383/7305)   
[0:01:46] remote: Total 7305 (delta 5156), reused 7305 (delta 5156)        
[0:01:46] Receiving objects: 100% (7305/7305)   
[0:01:46] Resolving deltas:   0% (0/5156)   
[0:01:47] Resolving deltas:  10% (521/5156)   
[0:01:47] Resolving deltas: 100% (5156/5156)   
[0:01:47] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:01:47] fatal: The remote end hung up unexpectedly
[0:01:48] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:01:48] fatal: The remote end hung up unexpectedly
[0:01:49] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:01:49] fatal: The remote end hung up unexpectedly
[0:01:52] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:01:52] fatal: The remote end hung up unexpectedly
[0:01:56] _____ Conflicting directory found in /tmp/clean_engine/src/third_party/dart/third_party/pkg_tested/dart_style. Moving to /tmp/clean_engine/_bad_scm/src/third_party/dart/third_party/pkg_tested/dart_styleq3i438an.
[0:01:56] 
[0:01:56] 
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/dart_style.git /tmp/clean_engine/src/third_party/dart/third_party/pkg_tested/_gclient_dart_style_gfo01p6r' in '/tmp/clean_engine'

[0:01:56] Cloning into '/tmp/clean_engine/src/third_party/dart/third_party/pkg_tested/_gclient_dart_style_gfo01p6r'...
[0:01:56] remote: Counting objects: 1           
[0:01:56] remote: Counting objects: 84, done        
[0:01:56] Receiving objects:   0% (1/7305)   
[0:01:56] Receiving objects:  10% (731/7305)   
[0:01:56] remote: Total 7305 (delta 5156), reused 7305 (delta 5156)        
[0:01:56] Receiving objects: 100% (7305/7305)   
[0:01:56] Resolving deltas:   0% (0/5156)   
[0:01:56] Resolving deltas:  10% (526/5156)   
[0:01:57] Resolving deltas: 100% (5156/5156)   
[0:01:57] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:01:57] fatal: The remote end hung up unexpectedly
[0:01:58] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:01:58] fatal: The remote end hung up unexpectedly
[0:01:59] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:01:59] fatal: The remote end hung up unexpectedly
[0:02:01] error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400 Bad Request
[0:02:01] fatal: The remote end hung up unexpectedly
----------------------------------------
Error: Command 'git -c core.deltaBaseCacheLimit=2g fetch origin 0fe592042eda5d9eea6fc240a8ee0fe531bb0794 --no-tags' returned non-zero exit status 128 in /tmp/clean_engine/src/third_party/dart/third_party/pkg_tested/dart_style


Warnings:
Conflicting directory /tmp/clean_engine/src/third_party/dart/third_party/pkg_tested/dart_style moved to /tmp/clean_engine/_bad_scm/src/third_party/dart/third_party/pkg_tested/dart_styleq3i438an.
@chinmaygarde chinmaygarde added team-infra Owned by Infrastructure team P0 Critical issues such as a build break or regression labels Jul 12, 2021
@chinmaygarde
Copy link
Member Author

I was able to run this locally but @freiling wasn't. When attempting to run git show 0fe592042eda5d9eea6fc240a8ee0fe531bb0794, his result was fatal: bad object 0fe592042eda5d9eea6fc240a8ee0fe531bb0794. while mine was

commit 0fe592042eda5d9eea6fc240a8ee0fe531bb0794 (HEAD, origin/bump-2.0.2)
Author: Robert Nystrom <rnystrom@google.com>
Date:   Fri Jul 2 14:48:25 2021 -0700

    Bump version to publish 2.0.2.

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4903665..a3e9013 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,4 @@
-# 2.0.2-dev
+# 2.0.2
 
 * Don't unnecessarily split argument lists with `/* */` comments (#837).
 * Return correct exit code from `FormatCommand` when formatting stdin (#1035).
diff --git a/lib/src/cli/formatter_options.dart b/lib/src/cli/formatter_options.dart
index a60cc7f..ac888ab 100644
--- a/lib/src/cli/formatter_options.dart
+++ b/lib/src/cli/formatter_options.dart
@@ -13,7 +13,7 @@ import 'show.dart';
 import 'summary.dart';
 
 // Note: The following line of code is modified by tool/grind.dart.
-const dartStyleVersion = '2.0.1';
+const dartStyleVersion = '2.0.2';
 
 /// Global options that affect how the formatter produces and uses its outputs.
 class FormatterOptions {
diff --git a/pubspec.yaml b/pubspec.yaml
index 7bc89ec..8665162 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: dart_style
 # Note: See tool/grind.dart for how to bump the version.
-version: 2.0.2-dev
+version: 2.0.2
 description: >-
   Opinionated, automatic Dart source code formatter.
   Provides an API and a CLI tool.
(END)

Note that origin/bump-2.0.2 that I have locally is not present on the remote https://dart.googlesource.com/dart_style/+refs.

The commit seems to have been authored by @munificent. Perhaps a deleted branch is being referenced?

@zanderso zanderso added this to New in Infra Ticket Queue via automation Jul 13, 2021
@zanderso zanderso added the dependency: dart Dart team may need to help us label Jul 13, 2021
@dnfield
Copy link
Contributor

dnfield commented Jul 13, 2021

Are we running into resource request limits for Git on Borg?

@dnfield dnfield mentioned this issue Jul 13, 2021
Merged
@whesse
Copy link
Contributor

whesse commented Jul 13, 2021

The dart_style hash in DEPS is wrong, and does not refer to the 2.0.2 commit on the master branch and tagged with label '2.0.2'.
I will restore the lost commit with that hash, and correct the hash to the right one.

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jul 13, 2021
@whesse
Update dart_style to published version 2.0.2
6c92e18 
Dart_style 2.0.2 was published with more fixes and a different
hash than the original 2.0.2 commit hash.

Bug: flutter/flutter#86326
Change-Id: I31e8e9a0c6178d38ad62065df869807b899d313c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206543
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: William Hesse <whesse@google.com>
@whesse whesse mentioned this issue Jul 13, 2021
Closed
@chinmaygarde chinmaygarde mentioned this issue Jul 13, 2021
Merged
@yusufm yusufm moved this from New to Triaged in Infra Ticket Queue Jul 13, 2021
@yusufm yusufm moved this from Triaged to In progress in Infra Ticket Queue Jul 13, 2021
@yusufm
Copy link
Contributor

yusufm commented Jul 13, 2021

https://ci.chromium.org/p/flutter/g/engine/console is not showing any more purple, so closing this. Please reopen if this continues to be a problem.

@yusufm yusufm closed this as completed Jul 13, 2021
Infra Ticket Queue automation moved this from In progress to Done Jul 13, 2021
@yusufm yusufm self-assigned this Jul 13, 2021
@jason-simmons jason-simmons mentioned this issue Jul 13, 2021
Merged
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jul 19, 2021
@whesse
Update dart_style to published version 2.0.2
9156e75 
Dart_style 2.0.2 was published with more fixes and a different
hash than the original 2.0.2 commit hash.

Bug: flutter/flutter#86326
Change-Id: I31e8e9a0c6178d38ad62065df869807b899d313c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206543
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: William Hesse <whesse@google.com>
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yusufm yusufm

Labels
dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team
Projects
No open projects
Infra Ticket Queue
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chinmaygarde @yusufm @whesse @zanderso @dnfield