Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

painting and widgets libraries should export FontFeature #87235

Closed
Hixie opened this issue Jul 28, 2021 · 6 comments
Closed

painting and widgets libraries should export FontFeature #87235

Hixie opened this issue Jul 28, 2021 · 6 comments
Assignees
@Hixie
Labels
a: quality A truly polished experience framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@Hixie
Copy link
Contributor

Hixie commented Jul 28, 2021

Since FontFeature is part of the TextStyle API in painting, and TextStyle is part of the Text API in widgets, both should export FontFeature.

Ideally we'd have a lint that catches this kind of thing. A library should export all the types in the APIs it exposes.

cc @a14n
@Hixie Hixie added framework flutter/packages/flutter repository. See also f: labels. a: quality A truly polished experience P3 Issues that are less important to the Flutter project labels Jul 28, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Jul 28, 2021

Similar problem with ImageFilter.

@Hixie
Copy link
Contributor Author

Hixie commented Aug 5, 2021

Similarly material should expose SystemUiOverlayStyle since it's used in AppBar.

@Hixie
Copy link
Contributor Author

Hixie commented Aug 6, 2021

DragStartBehavior is used by a bunch of things in widgets but not re-exported.

@Hixie
Copy link
Contributor Author

Hixie commented Sep 7, 2021

LogicalKeyboardKey and a number of related types are exposed by Focus but not re-exported.

@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
@Hixie Hixie self-assigned this Nov 24, 2023
@Hixie Hixie mentioned this issue Nov 24, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/packages that referenced this issue Nov 28, 2023
@Hixie
[rfw, flutter_markdown] Prepare for removing dart:ui imports. (#5471)
e4aaba8 
See flutter/flutter#138881
Fixes parts of flutter/flutter#87235
@Hixie
Copy link
Contributor Author

Hixie commented Nov 29, 2023

i'm going to close this one and fix it on a case-by-case basis when i run into it.

@Hixie Hixie closed this as completed Nov 29, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this issue Dec 13, 2023
@Hixie @HugoOlthof
[rfw, flutter_markdown] Prepare for removing dart:ui imports. (flutte…
98b0f1b 
…r#5471)

See flutter/flutter#138881
Fixes parts of flutter/flutter#87235
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Hixie Hixie

Labels
a: quality A truly polished experience framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hixie @mamuseferha