Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugProfileBuildsEnabled and other equivalents should include arguments #93009

Closed
Hixie opened this issue Nov 3, 2021 · 3 comments · Fixed by #93086
Closed

debugProfileBuildsEnabled and other equivalents should include arguments #93009

Hixie opened this issue Nov 3, 2021 · 3 comments · Fixed by #93086
Assignees
@Hixie
Labels
a: debugging Debugging, breakpoints, expression evaluation framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list waiting for PR to land (fixed) A fix is in flight

Comments

@Hixie
Copy link
Contributor

Hixie commented Nov 3, 2021

...with debugCreator, widget constructor location from the widget inspector, etc.

cc @goderbauer
@Hixie Hixie added framework flutter/packages/flutter repository. See also f: labels. a: debugging Debugging, breakpoints, expression evaluation P2 Important issues not at the top of the work list labels Nov 3, 2021
@Hixie Hixie self-assigned this Nov 3, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Nov 3, 2021

(in the Timeline.startSync call, that is)

@Hixie
Copy link
Contributor Author

Hixie commented Nov 3, 2021

maybe the whole debugFillProperties list?

@Hixie Hixie added the waiting for PR to land (fixed) A fix is in flight label Nov 4, 2021
@Hixie Hixie mentioned this issue Nov 4, 2021
Closed
@Hixie Hixie mentioned this issue Nov 4, 2021
Merged
Hixie added a commit to Hixie/flutter that referenced this issue Dec 10, 2021
@Hixie
Improve tracing
c5993ae 
* Add a test for tracing the framework.
* Add a `DiagnosticsNode.toTimelineArguments()` that can be used easily with `Timeline.startSync`.
* Rename some of the timeline events for clarity: hot reload dirtying now says "Hot Reload" for example, and the phases are in all caps (BUILD, LAYOUT, etc).
* Always flag intrinsic and dry layout logic in debug and profile builds. Normally this only flags one event; when `debugProfileLayoutsEnabled` is true it shows the entire path. Might be good to have this flagged in the DevTools. Fixes flutter#93031.
* Fix a broken link by pointing to our official documentation instead of Fuchsia documentation. Fixes flutter#92044.
* Change how painting is traced when `debugProfilePaintsEnabled` is on to be more comprehensive.
* Add some details to the top-level timeline events, e.g. what nodes are dirty, when the relevant `debugProfile*Enabled` flags are on.
* Include the Diagnosticable information about a `RenderObject` or a `Widget` in the information logged when `debugProfileLayoutsEnabled`, `debugProfilePaintsEnabled`, or `debugProfileBuildsEnabled` are on. Fixes flutter#93009
* Refactor how tracing is done in the widgets library so that `RenderObjectWidget`s are included in the timeline when `debugProfileBuildsEnabled` is on. Fixes flutter#93007.

Also:

* Fix a minor error we introduced with the null safety migration: `DiagnosticsNode.toDescription` should return non-null. (Most of the logic either assumed that or already enforced it.)
* Implement `debugFillProperties` for `Placeholder` and `RenderCustomPaint`, to help with the tests that were added.
* Remove a TODO in `objects.dart` that we're never going to get to.
* Improve some docs on `BuildContext`.
* Cache `_dirtyElements[index]` in `buildScope`.
* Improve docs for `operator ==` on `Widget`. Fixes flutter#49490.
* Remove some code duplication in `framework.dart`.
* Clean up `_NullWidget` a bit.
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Hixie Hixie

Labels
a: debugging Debugging, breakpoints, expression evaluation framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list waiting for PR to land (fixed) A fix is in flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve tracing Hixie/flutter
2 participants
@Hixie @mamuseferha