Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] RefreshIndicator is not shown on web browser #94677

Closed
cdprete opened this issue Dec 4, 2021 · 6 comments
Closed

[Web] RefreshIndicator is not shown on web browser #94677

cdprete opened this issue Dec 4, 2021 · 6 comments
Labels
r: solved Issue is closed as solved

Comments

@cdprete
Copy link

cdprete commented Dec 4, 2021

Hi.
I'm starting playing around with Flutter and I was trying to add the RefreshIndicator to the skeleton app, but this doesn't render at all on web, no matter if I use the AlwaysScrollableScrollPhysics or the BouncingScrollPhysics(parent: AlwaysScrollableScrollPhysics()).

The flutter doctor is actually the same in #94675.
I've tried with Chrome and Edge and I've the same issue on both.

Any clue?

Cheers,
Cosimo

@cdprete cdprete changed the title RefreshIndicator is not shown on web browser [Web] RefreshIndicator is not shown on web browser Dec 4, 2021
@darshankawar darshankawar added the in triage Presently being triaged by the triage team label Dec 6, 2021
@darshankawar
Copy link
Member

@cdprete
Thanks for the report. Although I do see the same behavior by wrapping ListView with RefreshIndicator which shows the progress indicator on mobile but not on web, but I am not sure if that's intended. Does the refresh indicator show up on a non-flutter web app ?

@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Dec 6, 2021
@cdprete
Copy link
Author

cdprete commented Dec 8, 2021 via email

@github-actions github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Dec 8, 2021
@darshankawar
Copy link
Member

@cdprete
I believe you are hitting https://docs.flutter.dev/release/breaking-changes/default-scroll-behavior-drag
Please check the migration guide and use the updated code as mentioned https://docs.flutter.dev/release/breaking-changes/default-scroll-behavior-drag#migration-guide and see if it works.

@darshankawar darshankawar added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Dec 9, 2021
@cdprete
Copy link
Author

cdprete commented Dec 9, 2021

@darshankawar that did indeed the trick.
There is a caveat, though: now the list is always scrollable.

Having a look at ListView, it seems like it always creates an AlwaysScrollableScrollPhysics if certain "conditions" are met, which is the case if you - like me - follow the migration guide but don't add the ScrollController because nowhere it's there written it's really needed and why it's needed.

That said, the issue is indeed fixed and I would just improve the docs if I would be at your place (e.g.: add the links to the migration in the docs of the scrollable default widgets and explain why ScrollController is always needed).

@github-actions github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Dec 9, 2021
@darshankawar
Copy link
Member

@cdprete
Thanks for the update. Since your original issue has been resolved, I'll close this one.
Regarding your other behavior you discovered, please file a new issue and we'll address it.

@darshankawar darshankawar added r: solved Issue is closed as solved and removed in triage Presently being triaged by the triage team labels Dec 10, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
r: solved Issue is closed as solved
Projects
None yet
Development

No branches or pull requests

2 participants