Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent failure to connect to chrome tabs on test bots #94886

Closed
annagrin opened this issue Dec 8, 2021 · 13 comments · Fixed by #98540 or #104218
Closed

Intermittent failure to connect to chrome tabs on test bots #94886

annagrin opened this issue Dec 8, 2021 · 13 comments · Fixed by #98540 or #104218
Assignees
@christopherfujino @annagrin
Labels
c: flake Tests that sometimes, but not always, incorrectly pass P1 High-priority issues at the top of the work list platform-web Web applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@annagrin
Copy link
Contributor

annagrin commented Dec 8, 2021 •
edited by christopherfujino
Loading

Part of issues causing web_tool_tests bot failures. See parent issue: #93256

From build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tool_tests/4272/overview

01:36 +3 -1: test/web.shard/vm_service_web_test.dart: Clients of flutter run on web with DDS enabled can validate flutter version in parallel [E]                                                      
  Exception: Received app.stop event while waiting for app.started event
  
  [+1795 ms] FormatException: Unexpected character (at character 1)
         <html>
         ^

         #0      _ChunkedJsonParser.fail (dart:convert-patch/convert_patch.dart:1405:5)
         #1      _ChunkedJsonParser.parseNumber (dart:convert-patch/convert_patch.dart:1272:9)
         #2      _ChunkedJsonParser.parse (dart:convert-patch/convert_patch.dart:937:22)
         #3      _parseJson (dart:convert-patch/convert_patch.dart:40:10)
         #4      JsonDecoder.convert (dart:convert/json.dart:612:36)
         #5      JsonCodec.decode (dart:convert/json.dart:216:41)
         #6      jsonDecode (dart:convert/json.dart:155:10)
         #7      ChromeConnection.getTabs (package:webkit_inspection_protocol/webkit_inspection_protocol.dart:44:10)
         <asynchronous suspension>
         #8      ChromeConnection.getTab (package:webkit_inspection_protocol/webkit_inspection_protocol.dart:57:25)
         <asynchronous suspension>
         #9      ChromiumLauncher._connect (package:flutter_tools/src/web/chrome.dart:401:9)
         <asynchronous suspension>
         #10     ChromiumDevice.startApp (package:flutter_tools/src/web/web_device.dart:134:17)
         <asynchronous suspension>
         #11     ResidentWebRunner.run.<anonymous closure> (package:flutter_tools/src/isolated/resident_web_runner.dart:307:9)
         <asynchronous suspension>
         #12     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:24)
         <asynchronous suspension>

  Unable to connect to Chrome debug port: 40881
@annagrin annagrin self-assigned this Dec 8, 2021
@annagrin annagrin mentioned this issue Dec 8, 2021
Closed
@darshankawar darshankawar added in triage Presently being triaged by the triage team platform-web Web applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. passed first triage and removed in triage Presently being triaged by the triage team labels Dec 9, 2021
@annagrin annagrin removed their assignment Dec 14, 2021
@annagrin
Copy link
Contributor Author

@christopherfujino @yjbanov would you be able to help with this? It seems that the http://localhost:<chrome devtools port>/json returns an html page instead of json. This is not related to dwds, could it be an issue in chrome or flutter tools?

Note that this issue seem to cause about 1% flakiness in web_tool_tests bots.

@annagrin annagrin added in triage Presently being triaged by the triage team passed secondary triage P1 High-priority issues at the top of the work list and removed in triage Presently being triaged by the triage team labels Dec 14, 2021
@annagrin
Copy link
Contributor Author

@christopherfujino assigning this to you per our chat.

@darshankawar darshankawar mentioned this issue Jan 27, 2022
Closed
@zanderso zanderso mentioned this issue Jan 31, 2022
Closed
@zanderso
Copy link
Member

This was flagged again in #97526 on the same tests.

@annagrin @yjbanov @christopherfujino Please evaluate the value of this test and consider whether we should just delete it.

@zanderso zanderso mentioned this issue Jan 31, 2022
Closed
@keyonghan keyonghan mentioned this issue Feb 1, 2022
Open
70 tasks
@keyonghan
Copy link
Contributor

Bumping the priority to P1 considering high flaky percentage.

@keyonghan keyonghan added P1 c: flake Tests that sometimes, but not always, incorrectly pass and removed P1 High-priority issues at the top of the work list labels Feb 1, 2022
@keyonghan
Copy link
Contributor

Another instance: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tool_tests/4893/overview

@christopherfujino christopherfujino mentioned this issue Feb 16, 2022
Merged
@annagrin
Copy link
Contributor Author

/cc @bkonyi this test was testing a simultaneous connection to dds - maybe we should consider adding a similar test to dds itself to prevent regressions?

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
@keyonghan
Copy link
Contributor

This is still happening: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tool_tests/5376/overview

@keyonghan keyonghan reopened this Mar 24, 2022
@zanderso zanderso added P1 High-priority issues at the top of the work list and removed P1 labels Mar 24, 2022
@zanderso
Copy link
Member

Reducing priority to P3 since this seems to be below the threshold.

@keyonghan
Copy link
Contributor

Another one: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tool_tests/5556/overview

@keyonghan
Copy link
Contributor

Another two:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tool_tests/5869/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_tool_tests/6010/overview

@annagrin
Copy link
Contributor Author

annagrin commented May 7, 2022

filed an issue google/webkit_inspection_protocol.dart#85 to retry getting the tab list. Not sure why chrome sometimes returns an html page instead of json.

@annagrin
Copy link
Contributor Author

Fix is in #104218

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christopherfujino christopherfujino

@annagrin annagrin

Labels
c: flake Tests that sometimes, but not always, incorrectly pass P1 High-priority issues at the top of the work list platform-web Web applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
5 participants
@zanderso @christopherfujino @annagrin @keyonghan @darshankawar