-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry getting tabs in chrome launcher on ConnectionException #104218
Retry getting tabs in chrome launcher on ConnectionException #104218
Conversation
…er into annagrin/web-tests-flakes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 nit
Co-authored-by: Christopher Fujino <fujino@google.com>
@annagrin marked "Google testing" green because the CL says pre-submits passed, I'm guessing this is a FRoB bug. This is good to go! |
Thanks, they were failing of a reason at first - package:webkit_inspection_protocol needed to be updated - so I fixed it and rerun the tests (that's why they were showing as passing) but the CI did not detect it for some reason. |
Add more information and potentially resolve
web_tool_tests
flakes caused by failure to get a tab list from Chrome on launch.flutter update-packages --force-upgrade
to bring newpackage:webkit_inspection_protocol.dart
and more.retryFor
duration so we try getting tabs for a couple of seconds.ChromeLauncher.connect
API available for testing.ChromeLauncher.connect
.Closes: #94886
Pre-launch Checklist
///
).