Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter run hangs if adb hangs #9567

Closed
tvolkert opened this issue Apr 24, 2017 · 1 comment · Fixed by #9611
Closed

flutter run hangs if adb hangs #9567

tvolkert opened this issue Apr 24, 2017 · 1 comment · Fixed by #9611
Milestone
3: Current Milestone

Comments

@tvolkert
Copy link
Contributor

We've received a few reports of flutter run hanging, where it looks like the underlying cause is that adb has hung and is only fixed by unplugging and re-plugging the phone in via USB.

This shouldn't cause Flutter to hang and is doing so because we're using Process.runSync() instead of Process.run(), thus pausing the entire isolate until the process exits (which it never does).

This is one particular manifestation of #7102
@tvolkert tvolkert added this to the 3: Make conferences happy milestone Apr 24, 2017
@tvolkert tvolkert mentioned this issue Apr 25, 2017
Merged
tvolkert added a commit that referenced this issue Apr 26, 2017
@tvolkert
Switch many Device methods to be async (#9587)
60c5ffc 
`adb` can sometimes hang, which will in turn hang the Dart isolate if
we're using `Process.runSync()`. This changes many of the `Device` methods
to return `Future<T>` in order to allow them to use the async process
methods. A future change will add timeouts to the associated calls so
that we can properly alert the user to the hung `adb` process.

This is work towards #7102, #9567
@tvolkert tvolkert mentioned this issue Apr 26, 2017
Merged
tvolkert added a commit that referenced this issue Apr 26, 2017
@tvolkert
Run async when calling adb shell getprop (#9611)
aaaae26 
Also, add a timeout so a hung `adb` will not cause the
tools process to hang.

Fixes #9567
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3: Current Milestone
Development

Successfully merging a pull request may close this issue.

Run async when calling adb shell getprop
1 participant
@tvolkert