Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branched out recipes not using drones from the same package #97181

Closed
godofredoc opened this issue Jan 25, 2022 · 3 comments
Closed

Branched out recipes not using drones from the same package #97181

godofredoc opened this issue Jan 25, 2022 · 3 comments
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
Better Flutter Releases

Comments

@godofredoc
Copy link
Contributor

Release presubmit builds are now using branched out recipe bundles. This means that if a builder is coming from branch flutter-2.8-candidate.16 then a cipd bundle with a ref of refs/for/heads/flutter-2.8-candidate.16 is used to run tests. The problem is that when calling subbuilds the cipd bundle parameter is not being overwritten causing the subbuilds to use the cipd bundle with ref refs/for/heads/main which contain the latest version of the recipes instead of the branched out one.
@godofredoc godofredoc added this to Untriaged in Better Flutter Releases via automation Jan 25, 2022
@godofredoc
Copy link
Contributor Author

\cc @itsjustkevin

godofredoc added a commit to godofredoc/cocoon that referenced this issue Jan 25, 2022
@godofredoc
Pass cipd_exe_version to builders.
d641edb 
This is needed to allow the subbuilds to run from the same package
version as the main build.

Bug: flutter/flutter#97181
@godofredoc godofredoc mentioned this issue Jan 25, 2022
Merged
8 tasks
@darshankawar darshankawar added in triage Presently being triaged by the triage team team Infra upgrades, team productivity, code health, technical debt. See also team: labels. and removed in triage Presently being triaged by the triage team labels Jan 25, 2022
@godofredoc godofredoc moved this from Untriaged to To do in Better Flutter Releases Jan 25, 2022
@godofredoc godofredoc moved this from To do to In progress in Better Flutter Releases Jan 25, 2022
@godofredoc
Copy link
Contributor Author

Fixed with:

https://flutter-review.googlesource.com/c/infra/+/25680

Better Flutter Releases automation moved this from In progress to Done Feb 5, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
Better Flutter Releases
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@godofredoc @darshankawar