Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests to validate architectures of built macOS app #97978

Closed
Tracked by #60113
jmagman opened this issue Feb 7, 2022 · 4 comments
Closed
Tracked by #60113

Add integration tests to validate architectures of built macOS app #97978

jmagman opened this issue Feb 7, 2022 · 4 comments
Assignees
@jmagman
Labels
a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list platform-host-arm Building on an ARM-based platform platform-mac Building on or for macOS specifically

Comments

@jmagman
Copy link
Member

jmagman commented Feb 7, 2022 •
edited
Loading

Something like

flutter/packages/flutter_tools/test/integration.shard/ios_content_validation_test.dart

Line 233 in 6ab0075

testWithoutContext('builds all plugin architectures for simulator', () {

in macos_content_validation_test. Validate x86_64 is built in release mode. When #60113 is complete, also check arm64[e] is also built in release mode.
@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests platform-mac Building on or for macOS specifically a: desktop Running on desktop platform-host-arm Building on an ARM-based platform labels Feb 7, 2022
@jmagman jmagman mentioned this issue Feb 7, 2022
Closed
10 tasks
@gspencergoog gspencergoog added the P2 Important issues not at the top of the work list label Feb 17, 2022
@cbracken cbracken mentioned this issue Mar 22, 2022
Merged
8 tasks
@cbracken cbracken self-assigned this Mar 22, 2022
cbracken added a commit that referenced this issue Mar 22, 2022
@cbracken
[macOS] Add run release test in devicelab (#100526)
4b81978 
Adds a test that invokes flutter run in release mode on macOS desktop,
waits for successful launch and the flutter command list, then sends the
'q' command to quit the running app.

This adds an integration test for #100504.

Issue: #100348 (fix)
Issue: #97978 (partial fix)
Issue: #97977 (partial fix)
Umbrella issue: #60113
cbracken added a commit to cbracken/flutter that referenced this issue Mar 22, 2022
@cbracken
[macOS] Ignore stderr contents in launch test
eccc7d7 
In the run_release_test_macos integration test that verifies that a
release build of an app can be launched (and quit), xcodebuild from the
Xcode install on the macOS bots emits a few info messages about
Simulator SDK versions that are irrelevant to the functioning of this
test.

Ignore these instead of failing the test if they occur.

Related: flutter#100526

Issue: flutter#100348 (fix)
Issue: flutter#97978 (partial fix)
Issue: flutter#97977 (partial fix)
Umbrella issue: flutter#60113
@cbracken cbracken mentioned this issue Mar 22, 2022
Merged
8 tasks
cbracken added a commit that referenced this issue Mar 23, 2022
@cbracken
[macOS] Ignore stderr contents in launch test (#100591)
e827f0b 
In the run_release_test_macos integration test that verifies that a
release build of an app can be launched (and quit), xcodebuild from the
Xcode install on the macOS bots emits a few info messages about
Simulator SDK versions that are irrelevant to the functioning of this
test.

Ignore these instead of failing the test if they occur.

Related: #100526

Issue: #100348 (fix)
Issue: #97978 (partial fix)
Issue: #97977 (partial fix)
Umbrella issue: #60113
@cbracken
Copy link
Member

cbracken commented Aug 5, 2022

Dependent on #42281.

@cbracken cbracken removed their assignment Aug 5, 2022
@jmagman
Copy link
Member Author

jmagman commented Aug 5, 2022

Actually I already did this in #100811, forgot I filed this issue.

flutter/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart

Lines 95 to 103 in f1f559d

final bool containsX64 = archs.contains('Mach-O 64-bit dynamically linked shared library x86_64');
final bool containsArm = archs.contains('Mach-O 64-bit dynamically linked shared library arm64');
if (buildModeLower == 'debug') {
// Only build the architecture matching the machine running this test, not both.
expect(containsX64 ^ containsArm, isTrue, reason: 'Unexpected architecture $archs');
} else {
expect(containsX64, isTrue, reason: 'Unexpected architecture $archs');
expect(containsArm, isTrue, reason: 'Unexpected architecture $archs');
}

@jmagman jmagman closed this as completed Aug 5, 2022
@cbracken
Copy link
Member

And just as bad, I forgot I reviewed it!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmagman jmagman

Labels
a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list platform-host-arm Building on an ARM-based platform platform-mac Building on or for macOS specifically
Projects
Flutter Desktop
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbracken @jmagman @gspencergoog