-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter_web] Add Support for Custom Map Tile Overlays #98596
Comments
We are also looking at this. All the other things seem to be working fine on web. |
…r/flutter#98596) Saves tile bytes to blobs and uses `img` elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.
…#98596) Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
…r/flutter#98596) Saves tile bytes to blobs and uses `img` elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.
…#98596) Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
…r/flutter#98596) Saves tile bytes to blobs and uses `img` elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.
…#98596) Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
…r/flutter#98596) Saves tile bytes to blobs and uses `img` elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.
…#98596) Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
If there's active interest for this, I have a couple commits at flutter/plugins@main...AsturaPhoenix:flutter-plugins:overlay that I could look into getting up to scratch for a pull request. So far I've only lightly tested it in my own use case (e.g. I haven't tried it in a mobile browser yet). |
…r/flutter#98596) Saves tile bytes to blobs and uses `img` elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.
…#98596) Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
Thanks for the contribution @AsturaPhoenix! My team has been using your fork in our project and it's worked real well. You can imagine our excitement when my issue from nearly a year ago gets this kind of reply. We are also seeing massive performance issues. I thought it would be around the serialization and deserialization of the tiles over the platform channels, but it seems like you've done a much more thorough investigation in the other issue you've linked to here (#116132). We are very interested in improvement the performance, as well as getting this module merged into the main code repository, so if you can think of anything we could do in service of that, let us know. I'm very pleased with how quickly we were able to get your code working here. So thanks again! |
@martyfuhry I think tests are (probably) the main thing standing between this and a pull request, so if you'd be willing to do that, that would be amazing. Otherwise, I can add a couple over the weekend and we can see where we are on Monday. Regarding performance, it seems to me like that'll be a considerably larger discussion, but it looks like getting this into a PR might be a first step towards starting that discussion. |
So, what is the situation here? Is someone actively working on this? Could I be of any help? |
This is a resubmission of flutter/plugins#6982 from the now archived flutter plugins repo. I'm submitting the changes from the original author, @AsturaPhoenix. The original description is below. -------- Saves tile bytes to blobs and uses img elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images. **Issue:** Fixes flutter/flutter#98596 **Known issues:** - flutter/flutter#116132 - AsturaPhoenix/trip_planner_aquamarine#22
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Use case
Google Maps for Android and iOS have supported custom map tile overlays since 1.2. They've been working great in our Android and iOS applications. We would like to also compile our application for the web, but google_maps_flutter_web doesn't support custom map tiles.
Proposal
As of version 0.2.0, google_maps_flutter_web simply noops any functionality related to custom tile overlays. Instead, google_maps_flutter_web should implement custom tile overlays, as the Google Maps Javascript platform supports this. We would like to use tile overlays in our web application in the same way as our mobile applications.
The text was updated successfully, but these errors were encountered: