Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter_web] Add Support for Custom Map Tile Overlays #98596

Closed
martyfuhry opened this issue Feb 16, 2022 · 6 comments · Fixed by flutter/packages#3538
Closed

[google_maps_flutter_web] Add Support for Custom Map Tile Overlays #98596

martyfuhry opened this issue Feb 16, 2022 · 6 comments · Fixed by flutter/packages#3538
Labels
c: proposal A detailed proposal for a change to Flutter p: maps Google Maps plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@martyfuhry
Copy link

Use case

Google Maps for Android and iOS have supported custom map tile overlays since 1.2. They've been working great in our Android and iOS applications. We would like to also compile our application for the web, but google_maps_flutter_web doesn't support custom map tiles.

Proposal

As of version 0.2.0, google_maps_flutter_web simply noops any functionality related to custom tile overlays. Instead, google_maps_flutter_web should implement custom tile overlays, as the Google Maps Javascript platform supports this. We would like to use tile overlays in our web application in the same way as our mobile applications.

@danagbemava-nc danagbemava-nc added the in triage Presently being triaged by the triage team label Feb 17, 2022
@danagbemava-nc danagbemava-nc changed the title Support for Custom Map Tile Overlays in Google Maps for Web [google_maps_flutter_web] Add Support for Custom Map Tile Overlays Feb 17, 2022
@danagbemava-nc danagbemava-nc added p: first party p: maps Google Maps plugin platform-web Web applications specifically c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Feb 17, 2022
@stuartmorgan stuartmorgan added the P2 Important issues not at the top of the work list label Feb 17, 2022
@vanlooverenkoen
Copy link
Contributor

We are also looking at this. All the other things seem to be working fine on web.

AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 11, 2022
…r/flutter#98596)

Saves tile bytes to blobs and uses `img` elements to decode and render. Does not
implement opacity, perform caching, or serve placeholder images.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 11, 2022
…#98596)

Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 11, 2022
…r/flutter#98596)

Saves tile bytes to blobs and uses `img` elements to decode and render. Does not
implement opacity, perform caching, or serve placeholder images.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 11, 2022
…#98596)

Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 11, 2022
…r/flutter#98596)

Saves tile bytes to blobs and uses `img` elements to decode and render. Does not
implement opacity, perform caching, or serve placeholder images.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 11, 2022
…#98596)

Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 13, 2022
…r/flutter#98596)

Saves tile bytes to blobs and uses `img` elements to decode and render. Does not
implement opacity, perform caching, or serve placeholder images.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 13, 2022
…#98596)

Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
@AsturaPhoenix
Copy link

If there's active interest for this, I have a couple commits at flutter/plugins@main...AsturaPhoenix:flutter-plugins:overlay that I could look into getting up to scratch for a pull request. So far I've only lightly tested it in my own use case (e.g. I haven't tried it in a mobile browser yet).

image

AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 24, 2022
…r/flutter#98596)

Saves tile bytes to blobs and uses `img` elements to decode and render. Does not
implement opacity, perform caching, or serve placeholder images.
AsturaPhoenix added a commit to AsturaPhoenix/flutter-plugins that referenced this issue Nov 24, 2022
…#98596)

Clears the tile cache for an overlay by re-setting the overlay in the map `MVCArray`.
@martyfuhry
Copy link
Author

Thanks for the contribution @AsturaPhoenix! My team has been using your fork in our project and it's worked real well. You can imagine our excitement when my issue from nearly a year ago gets this kind of reply.

We are also seeing massive performance issues. I thought it would be around the serialization and deserialization of the tiles over the platform channels, but it seems like you've done a much more thorough investigation in the other issue you've linked to here (#116132).

We are very interested in improvement the performance, as well as getting this module merged into the main code repository, so if you can think of anything we could do in service of that, let us know. I'm very pleased with how quickly we were able to get your code working here. So thanks again!

@AsturaPhoenix
Copy link

AsturaPhoenix commented Jan 13, 2023

@martyfuhry I think tests are (probably) the main thing standing between this and a pull request, so if you'd be willing to do that, that would be amazing. Otherwise, I can add a couple over the weekend and we can see where we are on Monday.

Regarding performance, it seems to me like that'll be a considerably larger discussion, but it looks like getting this into a PR might be a first step towards starting that discussion.

@Henk-Keijzer
Copy link

So, what is the situation here? Is someone actively working on this? Could I be of any help?

@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
@Hixie Hixie removed the plugin label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-web Owned by Web platform team triaged-web Triaged by Web platform team labels Jul 8, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jul 31, 2023
This is a resubmission of flutter/plugins#6982 from the now archived flutter plugins repo. I'm submitting the changes from the original author, @AsturaPhoenix. The original description is below.

--------

Saves tile bytes to blobs and uses img elements to decode and render. Does not implement opacity, perform caching, or serve placeholder images.

**Issue:** Fixes flutter/flutter#98596

**Known issues:**

- flutter/flutter#116132
- AsturaPhoenix/trip_planner_aquamarine#22
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: proposal A detailed proposal for a change to Flutter p: maps Google Maps plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants