New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put stretch indicator behind useMaterial3
flag
#100234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awesome Kate. I as just about to ask you what I needed to do for this 😄.
Can you also add a comment to the docs for useMaterial3
to indicate that it turns this feature on for Android platforms? Thx.
final AndroidOverscrollIndicator indicator = _androidOverscrollIndicator | ||
late final AndroidOverscrollIndicator indicator; | ||
if (Theme.of(context).useMaterial3) { | ||
indicator = AndroidOverscrollIndicator.stretch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only applies to the Android platform, correct? We don't perform the overscroll on anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct!
Gold has detected about 6 new digest(s) on patchset 2. |
Gold has detected about 1 new digest(s) on patchset 3. |
useMaterial3
flag
This updates the implementation of the stretching overscroll indicator to be enabled by the
useMaterial3
flag.It deprecates the previous
androidOverscrollIndicator
property, as part of unifying M3 features and making its way to the new default.Related to:
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.