Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update packages roller #100982

Merged

Conversation

christopherfujino
Copy link
Member

@christopherfujino christopherfujino commented Mar 29, 2022

First part of #106371

Once this merges, it will still not be productionized. Next steps will be to create a builder config, a recipe, and add it to .ci.yaml.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Mar 29, 2022
@christopherfujino christopherfujino force-pushed the add-update-packages-roller branch 2 times, most recently from 74cfcb7 to c88aeb7 Compare April 28, 2022 19:43
@christopherfujino christopherfujino marked this pull request as ready for review June 7, 2022 17:36
static const String hostname = 'github.com';

static const String prBody = '''
This PR was generated by `flutter update-packages --force-upgrade`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Flutter update-packages going to call this conductor logic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flow will be:

luci recipe -> dart packages_autoroller.dart -> flutter update-packages --force-upgrade

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the conductor codebase because it has abstractions for cloning the flutter/flutter repo in a somewhat hermetic environment, and there's both unit test and integration test infrastructure already set up.

dev/conductor/core/lib/src/packages_autoroller.dart Outdated Show resolved Hide resolved

Future<void> updatePackages({
bool verbose = true,
String author = 'flutter-packages-autoroller <flutter-packages-autoroller@google.com>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a google group?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the only member of which is the tools team.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't imagine anyone will be grepping the commit message and then emailing the address other than bots and recruiters though.

dev/conductor/core/lib/src/packages_autoroller.dart Outdated Show resolved Hide resolved
dev/conductor/core/lib/src/packages_autoroller.dart Outdated Show resolved Hide resolved
@fluttergithubbot fluttergithubbot merged commit a30012b into flutter:master Jun 23, 2022
@christopherfujino christopherfujino deleted the add-update-packages-roller branch June 23, 2022 00:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants