Remove redundant timeline_summary benchmarks from ci.yaml #101372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keyonghan ptal. Do I need to do anything else to keep these from running? |
dnfield
approved these changes
Apr 5, 2022
That's it. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 5, 2022
|
Were the results flatter/more consistent with E2E compared to timeline_summary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone over the results of these benchmarks in SkiaPerf, and the new
e2eversions appear to have been producing results that are consistent with the_timeline_summaryversions for quite some time.I am not deleting the benchmark code in this PR on the off chance that we need to run them locally to debug any weirdness that we might only notice now that the e2e versions of these are the only ones.