Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci.yaml] Migrate bringup targets to cocoon scheduler #102249

Merged
merged 2 commits into from
Apr 21, 2022
Merged

[ci.yaml] Migrate bringup targets to cocoon scheduler #102249

merged 2 commits into from
Apr 21, 2022

Conversation

CaseyHillers
Copy link
Contributor

#92300

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@CaseyHillers CaseyHillers mentioned this pull request Apr 20, 2022
Closed
19 tasks
keyonghan
keyonghan reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we relying on the checkout retry to bypass the issue or any other actions we have taken? What is the long term plan here?

@CaseyHillers
Copy link
Contributor Author

Are we relying on the checkout retry to bypass the issue or any other actions we have taken? What is the long term plan here?

Yes, it should only add a minute to the recipe runs. The copybara team is working on a way to send notifications via pubsub of when mirrors complete (ETA a quarter)

keyonghan
keyonghan approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_aar_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 4a72c53 into flutter:master Apr 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
4a72c5345 [ci.yaml] Migrate bringup targets to cocoon scheduler (flut…
301f05c 
…ter/flutter#102249)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
9788d27 
…r/flutter#102249)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
8651c7b 
…r/flutter#102249)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
ec06e51 
…r/flutter#102249)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
ca4f97d 
…r/flutter#102249)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 22, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
6bdfa2c 
…r/flutter#102249)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
2a1b66e 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
ff879c0 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
70840a1 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
96ee06f 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
e6e1ce6 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
eb15ed4 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
fe481fe 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
edd3e1f 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
1a8b05e 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
46e48c3 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
8a4bca6 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
be17607 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
afe98a3 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
859647e 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
218cbdb 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
5798bc1 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
d9501ed 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
2b6d3e9 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
4cd8221 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
bc5af1d 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
221bba9 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
74934b0 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
24789be 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
fc77c36 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
4468162 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
4115a64 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 27, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
a5126f6 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
b86c011 
…r/flutter#102249)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 28, 2022
@engine-flutter-autoroll
4a72c53 [ci.yaml] Migrate bringup targets to cocoon scheduler (flutte…
728c1ef 
…r/flutter#102249)
egramond pushed a commit to egramond/flutter that referenced this pull request May 5, 2022
@egramond
[ci.yaml] Migrate bringup targets to cocoon scheduler (flutter#102249)
4b22a59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CaseyHillers @fluttergithubbot @keyonghan @yusuf-goog