Fix empty Stack with infinite constraints throws #102642

bleroux · 2022-04-27T12:10:01Z

Description

Before this PR, when a Stack is empty and is given infinite constraints, an assertion error was thrown.
The previous assertion was added by the following PR : #16250

This PR update RenderStack to return the smallest valid Size instead of an assertion error.

Related Issue

Fixes #102640
Fixes #88575

Tests

Add one test in rendering/slack_test.dart

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

goderbauer · 2022-05-03T22:29:05Z

packages/flutter/lib/src/rendering/stack.dart

@@ -520,8 +520,7 @@ class RenderStack extends RenderBox
    assert(_resolvedAlignment != null);
    bool hasNonPositionedChildren = false;
    if (childCount == 0) {
-      assert(constraints.biggest.isFinite);
-      return constraints.biggest;
+      return constraints.smallest;


This is breaking existing behavior. If the biggest possible size the constraint allow is finite, the stack should continue to size itself to be as big as possible.

If that size is infinite, we could change this to the smallest possible size instead of asserting.

goderbauer

LGTM

…lutter#102642)

…tter#102642)

…lutter#102642)

Roll Flutter from b305eb633780 to 4c573207acc3 (33 revisions) flutter/flutter@b305eb6...4c57320 2022-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 71b9adccfb63 to 6248a5a9ae28 (1 revision) (flutter/flutter#103350) 2022-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3af7fb24d4dd to 71b9adccfb63 (1 revision) (flutter/flutter#103347) 2022-05-09 jesus_sguerrero@hotmail.com [flutter_tools] stringArg refactor (flutter/flutter#103231) 2022-05-09 maistho@gmail.com Replace ListView with ListView.builder for LicensesPage (flutter/flutter#102692) 2022-05-09 gspencergoog@users.noreply.github.com Adds `menuBarMenuLabel`, and removes unneeded key localizations (flutter/flutter#102100) 2022-05-09 engine-flutter-autoroll@skia.org Roll Plugins from 49b06b3 to c5c319a (15 revisions) (flutter/flutter#103345) 2022-05-09 engine-flutter-autoroll@skia.org Roll Engine from e7c44a582c58 to 3af7fb24d4dd (1 revision) (flutter/flutter#103334) 2022-05-09 engine-flutter-autoroll@skia.org Roll Engine from c02712fe1160 to e7c44a582c58 (1 revision) (flutter/flutter#103333) 2022-05-09 engine-flutter-autoroll@skia.org Roll Engine from 6efd8f00dcc6 to c02712fe1160 (1 revision) (flutter/flutter#103327) 2022-05-09 tessertaha@gmail.com `CupertinoTabScaffold`/`CupertinoTabController`: Add interactive examples (flutter/flutter#103196) 2022-05-09 engine-flutter-autoroll@skia.org Roll Engine from c930e64a13bc to 6efd8f00dcc6 (1 revision) (flutter/flutter#103323) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from d0e6e14d27cc to c930e64a13bc (2 revisions) (flutter/flutter#103308) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from fffb3eb58e7d to d0e6e14d27cc (1 revision) (flutter/flutter#103307) 2022-05-08 danny@tuppeny.com Use consistent date instead of DateTime.now() in evaluation tests (flutter/flutter#103269) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from 259ccadd8203 to fffb3eb58e7d (1 revision) (flutter/flutter#103298) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from 0b84783081a7 to 259ccadd8203 (1 revision) (flutter/flutter#103293) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from 19d5f037f221 to 0b84783081a7 (1 revision) (flutter/flutter#103291) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from 2d1f34cbdde2 to 19d5f037f221 (1 revision) (flutter/flutter#103289) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from b89e093d887f to 2d1f34cbdde2 (1 revision) (flutter/flutter#103287) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from aa80520b7fc9 to b89e093d887f (1 revision) (flutter/flutter#103286) 2022-05-08 engine-flutter-autoroll@skia.org Roll Engine from 4c05cb763866 to aa80520b7fc9 (1 revision) (flutter/flutter#103283) 2022-05-07 engine-flutter-autoroll@skia.org Roll Engine from 235d951ccfbd to 4c05cb763866 (1 revision) (flutter/flutter#103279) 2022-05-07 engine-flutter-autoroll@skia.org Roll Engine from 24466845e7a9 to 235d951ccfbd (4 revisions) (flutter/flutter#103276) 2022-05-07 engine-flutter-autoroll@skia.org Roll Engine from 2d2f8629cdb2 to 24466845e7a9 (1 revision) (flutter/flutter#103274) 2022-05-07 engine-flutter-autoroll@skia.org Roll Engine from 4a358030cb07 to 2d2f8629cdb2 (1 revision) (flutter/flutter#103273) 2022-05-07 fujino@google.com [flutter_tools] add --uninstall-first flag and pipe it through to ios-deploy (flutter/flutter#102948) 2022-05-07 xubaolin@oppo.com Fix a `_WrappedScrollBehavior.shouldNotify` bug (flutter/flutter#103267) 2022-05-07 magder@google.com Remove custom `unawaited`, prefer `dart:async` version (flutter/flutter#103212) 2022-05-07 36861262+QuncCccccc@users.noreply.github.com Added clipBehavior on TabBarView (flutter/flutter#103166) 2022-05-07 leroux_bruno@yahoo.fr Fix empty Stack with infinite constraints throws (flutter/flutter#102642) 2022-05-07 42252197+egramond@users.noreply.github.com Updating the Slider Widget to allow up and down arrow keys to navigate out of the slider when in directional NavigationMode. (flutter/flutter#103149) 2022-05-07 tessertaha@gmail.com Fix `DropdownButton` menu clip (flutter/flutter#102970) 2022-05-07 engine-flutter-autoroll@skia.org Roll Engine from 094cb30943a5 to 4a358030cb07 (1 revision) (flutter/flutter#103260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: ...

…lutter#102642)

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 27, 2022

goderbauer self-requested a review April 27, 2022 21:44

bleroux force-pushed the empty_stack_with_infinite_constraints branch from 59568fa to 09e4f8c Compare April 28, 2022 05:34

bleroux changed the title ~~Add an error message for empty Stack with infinite constraints~~ Fix empty Stack with infinite constraints throws Apr 28, 2022

bleroux mentioned this pull request Apr 28, 2022

fix AnimatedSwitcher in Flex and with null child crashes #102652

Closed

8 tasks

goderbauer reviewed May 3, 2022

View reviewed changes

bleroux force-pushed the empty_stack_with_infinite_constraints branch from 09e4f8c to c023b70 Compare May 4, 2022 07:37

bleroux requested a review from goderbauer May 4, 2022 09:19

goderbauer approved these changes May 4, 2022

View reviewed changes

bleroux added the waiting for tree to go green label May 5, 2022

bleroux force-pushed the empty_stack_with_infinite_constraints branch from c023b70 to 9783f39 Compare May 6, 2022 05:23

Fix empty Stack with infinite constraints throws

1ce7faf

bleroux force-pushed the empty_stack_with_infinite_constraints branch from 9783f39 to 1ce7faf Compare May 7, 2022 06:28

fluttergithubbot merged commit c180971 into flutter:master May 7, 2022

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from b305eb633780 to c18097178c91 (4 revisions) flutter/packages#1815

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

abb7273

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from b305eb633780 to c18097178c91 (4 revisions) flutter/packages#1816

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

961a7b2

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from ae7fcc7e51f6 to c18097178c91 (1 revision) flutter/plugins#5664

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 7, 2022

c180971 Fix empty Stack with infinite constraints throws (flutter/flu…

4fb934c

…tter#102642)

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from b305eb633780 to 2427d4f3d630 (5 revisions) flutter/packages#1817

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

6fcb59a

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from b305eb633780 to c6ced845e389 (6 revisions) flutter/packages#1818

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

11e9ec9

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from b305eb633780 to c6ced845e389 (6 revisions) flutter/packages#1819

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

75bdf71

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from b305eb633780 to 4bed76757db7 (7 revisions) flutter/packages#1820

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

dbb8083

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 7, 2022

Roll Flutter from b305eb633780 to f3f2909bf25a (9 revisions) flutter/packages#1821

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

b937c7f

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 4f1608a34930 (27 revisions) flutter/packages#1846

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

5ac596b

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 4f1608a34930 (27 revisions) flutter/packages#1847

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

40760d7

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 84ffdad368d9 (28 revisions) flutter/packages#1848

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

3a5f523

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 6504f2896ccb (29 revisions) flutter/packages#1849

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

8f15609

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 95116386b73b (30 revisions) flutter/packages#1850

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

f9752b0

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 596e9d1c47ac (31 revisions) flutter/packages#1851

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

2209705

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 65caffd40537 (32 revisions) flutter/packages#1853

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

928038c

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 4c573207acc3 (33 revisions) flutter/packages#1854

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

d1c9fee

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 106ab98f878b (34 revisions) flutter/packages#1855

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

ed0adcc

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 89f755c2df3e (35 revisions) flutter/packages#1856

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

416de1a

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 0ff0affb3a9d (36 revisions) flutter/packages#1858

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

369184a

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to ff136cba7fe0 (37 revisions) flutter/packages#1859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

6fdf9f6

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 16f3feaf0780 (38 revisions) flutter/packages#1860

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

88fa8e6

…lutter#102642)

engine-flutter-autoroll mentioned this pull request May 9, 2022

Roll Flutter from b305eb633780 to 93cce92ea827 (39 revisions) flutter/packages#1861

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022

c18097178 Fix empty Stack with infinite constraints throws (flutter/f…

35eb829

…lutter#102642)

bleroux deleted the empty_stack_with_infinite_constraints branch May 12, 2022 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix empty Stack with infinite constraints throws #102642

Fix empty Stack with infinite constraints throws #102642

bleroux commented Apr 27, 2022 •

edited

Loading

goderbauer May 3, 2022

goderbauer left a comment

Fix empty Stack with infinite constraints throws #102642

Fix empty Stack with infinite constraints throws #102642

Conversation

bleroux commented Apr 27, 2022 • edited Loading

Description

Related Issue

Tests

Pre-launch Checklist

goderbauer May 3, 2022

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment

bleroux commented Apr 27, 2022 •

edited

Loading