Update ffi gem installation instructions #103008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jmagman
added
platform-ios
cyanglaz
reviewed
May 4, 2022
| @@ -371,7 +371,7 @@ class CocoaPods { | |||
| ).send(); | |||
| _logger.printError( | |||
| 'Error: To set up CocoaPods for ARM macOS, run:\n' | |||
| ' arch -x86_64 sudo gem install ffi\n', | |||
| ' sudo gem uninstall ffi && sudo gem install ffi -- --enable-libffi-alloc\n', | |||
There was a problem hiding this comment.
What does the additional -- between "ffi" and "--enable-libffi-alloc" mean?
There was a problem hiding this comment.
I guess they aren't parsing it as a flag but as a string positional parameter? I don't know why they did it like that, but the -- is needed.
ffi/ffi#800 (comment)
| @@ -371,7 +371,7 @@ class CocoaPods { | |||
| ).send(); | |||
| _logger.printError( | |||
| 'Error: To set up CocoaPods for ARM macOS, run:\n' | |||
| ' arch -x86_64 sudo gem install ffi\n', | |||
| ' sudo gem uninstall ffi && sudo gem install ffi -- --enable-libffi-alloc\n', | |||
There was a problem hiding this comment.
Does the user need to have a specific gem version to have this flag? Or is it old enough we don't have to worry?
There was a problem hiding this comment.
If they run this command they will get the newest version.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 4, 2022
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the outdated Rosetta
arch -x86_64instructions to instead use the preferred--enable-libffi-allocflag whenpod installfails on machines using the default system version of Ruby. I used this command to getpod installworking on my new M1.ffi/ffi#800
Already updated https://github.com/flutter/flutter/wiki/Developing-with-Flutter-on-Apple-Silicon
See #99195
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.