Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tooltip obscured by keyboard #103339

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix Tooltip obscured by keyboard #103339

merged 1 commit into from
May 9, 2022

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented May 9, 2022

Description

This PR updates Tooltip positionning to avoid that tooltips are obscured by the keyboard.

Related Issue

Fixes #23666

Tests

Add one test in material/tooltip_test.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 9, 2022
@bleroux bleroux requested a review from chunhtai May 9, 2022 12:35
chunhtai
chunhtai approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit ff136cb into flutter:master May 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022
@engine-flutter-autoroll
ff136cba7 Fix Tooltip obscured by keyboard (flutter/flutter#103339)
99353ea
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022
@engine-flutter-autoroll
ff136cba7 Fix Tooltip obscured by keyboard (flutter/flutter#103339)
eb67343
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 9, 2022
@engine-flutter-autoroll
ff136cb Fix Tooltip obscured by keyboard (flutter/flutter#103339)
9d03fef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022
@engine-flutter-autoroll
ff136cba7 Fix Tooltip obscured by keyboard (flutter/flutter#103339)
e981d1a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 9, 2022
@engine-flutter-autoroll
ff136cb Fix Tooltip obscured by keyboard (flutter/flutter#103339)
47e4ddd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2022
@engine-flutter-autoroll
ff136cba7 Fix Tooltip obscured by keyboard (flutter/flutter#103339)
d593266
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 10, 2022
@engine-flutter-autoroll
ff136cb Fix Tooltip obscured by keyboard (flutter/flutter#103339)
00883a5
@bleroux bleroux deleted the tooltip_hidden_by_keyboard branch May 20, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltips should not be obscured by the keyboard
3 participants
@bleroux @chunhtai @fluttergithubbot