Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scrollbar]Skip the ScrollPosition check if the bar was unmounted #103948

Merged
merged 1 commit into from
May 19, 2022
Merged

[Scrollbar]Skip the ScrollPosition check if the bar was unmounted #103948

merged 1 commit into from
May 19, 2022

Conversation

xu-baolin
Copy link
Member

Fixes #103939

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 17, 2022
@xu-baolin xu-baolin requested a review from Piinks May 17, 2022 03:20
@caduandrade caduandrade mentioned this pull request May 17, 2022
Closed
Piinks
Piinks approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you - LGTM!

@fluttergithubbot fluttergithubbot merged commit 93211a4 into flutter:master May 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2022
@engine-flutter-autoroll
93211a48d [Scrollbar]Skip the ScrollPosition check if the bar was unm…
3fc9aa4 
…ounted (flutter/flutter#103948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
93211a4 [Scrollbar]Skip the ScrollPosition check if the bar was unmou…
f90667f 
…nted (flutter/flutter#103948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 19, 2022
@engine-flutter-autoroll
93211a4 [Scrollbar]Skip the ScrollPosition check if the bar was unmou…
b478cf9 
…nted (flutter/flutter#103948)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 21, 2022
@engine-flutter-autoroll
93211a4 [Scrollbar]Skip the ScrollPosition check if the bar was unmou…
b105706 
…nted (flutter/flutter#103948)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
93211a48d [Scrollbar]Skip the ScrollPosition check if the bar was unm…
b118e40 
…ounted (flutter/flutter#103948)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
93211a4 [Scrollbar]Skip the ScrollPosition check if the bar was unmou…
916b7c0 
…nted (flutter/flutter#103948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No ScrollPosition attached error message when widget is no more rebuild with a horizontal scrollbar
3 participants
@xu-baolin @Piinks @fluttergithubbot