Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Plugins from f4ca73237db8 to 99aa799ea07a (11 revisions) #104430

Conversation

engine-flutter-autoroll
Copy link
Contributor

@engine-flutter-autoroll engine-flutter-autoroll commented May 23, 2022

Fixes #104453

flutter/plugins@f4ca732...58478a5

2022-05-23 magder@google.com [google_maps_flutter] Fix prefer_const_literals_to_create_immutables (flutter/plugins#5811)
2022-05-23 stuartmorgan@google.com [google_maps_flutter] Updates platform interface to new analysis options (flutter/plugins#5793)
2022-05-23 martin.georgiu@gmail.com [Camera] Return all possible cameras on iOS (flutter/plugins#5636)
2022-05-23 tttkhs@naver.com [google_sign_in, in_app_purchase_android] Add availability to mock models (flutter/plugins#5642)
2022-05-21 engine-flutter-autoroll@skia.org Roll Flutter from de7c23e to ec20ea8 (1 revision) (flutter/plugins#5805)
2022-05-21 engine-flutter-autoroll@skia.org Roll Flutter from b8b0c80 to de7c23e (1 revision) (flutter/plugins#5804)
2022-05-21 engine-flutter-autoroll@skia.org Roll Flutter from 4654fd0 to b8b0c80 (1 revision) (flutter/plugins#5803)
2022-05-21 engine-flutter-autoroll@skia.org Roll Flutter from 6aaabf6 to 4654fd0 (2 revisions) (flutter/plugins#5802)
2022-05-21 engine-flutter-autoroll@skia.org Roll Flutter from 1e10cec to 6aaabf6 (1 revision) (flutter/plugins#5800)
2022-05-21 engine-flutter-autoroll@skia.org Roll Flutter from 1e1f4bc to 1e10cec (6 revisions) (flutter/plugins#5799)
2022-05-21 engine-flutter-autoroll@skia.org Roll Flutter from a4a8e73 to 1e1f4bc (65 revisions) (flutter/plugins#5795)
2022-05-20 asashour@yahoo.com [google_sign_in] Suppress deprecation warnings (flutter/plugins#5049)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac run_release_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac run_release_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac run_release_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@jmagman jmagman force-pushed the flutter-plugins-flutter-autoroll-3f3e0224-6fd5-4bfb-8621-2e75b4f2dade-1653329467 branch from d5bd244 to ec1f257 Compare May 23, 2022 22:04
@jmagman
Copy link
Member

jmagman commented May 23, 2022

Reopening and rebasing on main, will hopefully close #104453 by picking up flutter/plugins#5793

@jmagman
Copy link
Member

jmagman commented May 23, 2022

Adding reviewers so I can merge manually when https://ci.chromium.org/p/flutter/builders/try/Linux%20flutter_plugins/26159 passes.

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented May 23, 2022

https://ci.chromium.org/p/flutter/builders/try/Linux%20flutter_plugins/26159 still failed:

   info - example/integration_test/google_maps_controller_test.dart:148:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:149:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:162:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:163:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:176:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:177:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:190:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_controller_test.dart:191:17 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:236:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:237:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:246:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:247:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:256:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:257:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:266:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables
   info - example/integration_test/google_maps_plugin_test.dart:267:11 - Prefer const literals as parameters of constructors on @immutable classes. - prefer_const_literals_to_create_immutables

@bparrishMines
Copy link
Contributor

Yea, it looks like google_maps_flutter_web was missed in the PR: flutter/plugins#5793

@bparrishMines
Copy link
Contributor

I can create a PR, but I'm not sure why our CI didn't catch this

@jmagman
Copy link
Member

jmagman commented May 23, 2022

I can create a PR, but I'm not sure why our CI didn't catch this

Actually I already got it in flutter/plugins#5811.
Updated this roll to that SHA.

@jmagman
Copy link
Member

jmagman commented May 23, 2022

@jmagman jmagman merged commit 7ece8f9 into flutter:master May 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-plugins-flutter-autoroll-3f3e0224-6fd5-4bfb-8621-2e75b4f2dade-1653329467 branch May 30, 2022 18:24
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_maps_flutter_web has prefer_const_literals_to_create_immutables info warnings
5 participants