Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use curly_braces_in_flow_control_structures for material #104499

Merged
merged 4 commits into from May 25, 2022
Merged

Use curly_braces_in_flow_control_structures for material #104499

merged 4 commits into from May 25, 2022

Conversation

guidezpl
Copy link
Member

This doesn't turn on the lint yet.

#104498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 24, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer
goderbauer approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am in favor of turning this on for the whole repository. :)

@goderbauer
Copy link
Member

It looks like this pull request may not have tests.

Did you also run this over tests/material? Surprised that there wouldn't be a single test violating this.

@guidezpl
Copy link
Member Author

Did you also run this over tests/material? Surprised that there wouldn't be a single test violating this.

I didn't include them, I'll add them now.

@Hixie
Copy link
Contributor

Hixie commented May 24, 2022

test-exempt: refactors

werainkhatri
werainkhatri reviewed May 24, 2022
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe ignore: avoid_dynamic_calls was removed unintentionally?

packages/flutter/test/material/text_field_test.dart Show resolved Hide resolved
packages/flutter/test/material/text_field_test.dart Show resolved Hide resolved
@guidezpl
Copy link
Member Author

Indeed, comments were removed in 4 places, I'll add them back. Something to keep in mind for future PRs.

@werainkhatri
Copy link
Member

werainkhatri commented May 25, 2022 •
edited

Indeed, comments were removed in 4 places, I'll add them back. Something to keep in mind for future PRs.

was this because of the use of dart fix or a code action? maybe there's an issue waiting to be reported for them.

@guidezpl
Copy link
Member Author

This was because of dart fix.

@guidezpl guidezpl merged commit cb9a1d6 into flutter:master May 25, 2022
@guidezpl guidezpl deleted the curly_braces branch May 25, 2022 11:17
@guidezpl guidezpl mentioned this pull request May 25, 2022
Open
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2022
@engine-flutter-autoroll
cb9a1d623 Use curly_braces_in_flow_control_structures for material (
d11740e 
flutter/flutter#104499)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 25, 2022
@engine-flutter-autoroll
cb9a1d6 Use curly_braces_in_flow_control_structures for material (f…
c4a4ebb 
…lutter/flutter#104499)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
Use curly_braces_in_flow_control_structures for material (flutter…
579fd26 
…#104499)

* Use `curly_braces_in_flow_control_structures` for `material`

* include test/material

* add back removed comments
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
cb9a1d623 Use curly_braces_in_flow_control_structures for material (
386fe2d 
flutter/flutter#104499)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
cb9a1d6 Use curly_braces_in_flow_control_structures for material (f…
e4bba25 
…lutter/flutter#104499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werainkhatri werainkhatri werainkhatri left review comments

@goderbauer goderbauer goderbauer approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guidezpl @goderbauer @Hixie @werainkhatri