A bunch of cleanups and a missing ShortcutRegistar in WidgetsApp
#104560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: focus
dkwingsmt
reviewed
May 24, 2022
| @@ -1730,7 +1730,9 @@ class _WidgetsAppState extends State<WidgetsApp> with WidgetsBindingObserver { | |||
| actions: widget.actions ?? WidgetsApp.defaultActions, | |||
| child: FocusTraversalGroup( | |||
| policy: ReadingOrderTraversalPolicy(), | |||
| child: child, | |||
| child: ShortcutRegistrar( | |||
There was a problem hiding this comment.
This change does not look like a clean up. Is it intended?
There was a problem hiding this comment.
Ok I see you mentioning it in the PR. Maybe this should be the title of this PR.
There was a problem hiding this comment.
You're right, it's not really a "cleanup", but something that was missing from the previous PR that I committed with the ShortcutRegistry. Without this, people will have to add their own registrar manually.
I've added a test to make sure it exists.
gspencergoog
changed the title
MenuBar development.ShortcutRegistar in WidgetsApp
cbracken
approved these changes
May 25, 2022
|
This pull request is not suitable for automatic merging in its current state.
|
gspencergoog
force-pushed
the
menu_bar_extras
branch
from
2272134
to
6a41416
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
May 25, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…lutter#104560) A bunch of random cleanup things I found while doing MenuBar development. Changes an if test to an assert in binding.dart, since the if should always be true. Adds the default ShortcutRegistrar that should have been in the ShortcutRegistry PR. Moves a debug message in the FocusManager to print the result after the focus change instead of before. Reorders the test parameters in theme_data_test.dart to match the order of the theme data fields everywhere else.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bunch of random cleanup things I found while doing
MenuBardevelopment.binding.dart, since the if should always be true.ShortcutRegistrarthat should have been in theShortcutRegistryPR.FocusManagerto print the result after the focus change instead of before.Tests
ShortcutRegistarinWidgetsApp.