-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows manifest to declare Windows 11 #104768
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - perhaps "Windows 10 and later" rather than enumerating each version?
The risk is that some putative future Windows "12" might change the GUID, of course. For safety and conformance with Microsoft's guidance, I copied the sample manifest to the letter: https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-application-at-windows-8-1 |
Ah perfect then! |
Updates manifest comment to highlight Windows 11 compatibility. This is a comment-only change, so shouldn't require test changes.
List which issues are fixed by this PR. You must list at least one issue.
Fixes #104767
Pre-launch Checklist
///
).