Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more const immutable classes #104988

Merged
merged 2 commits into from
May 31, 2022
Merged

more const immutable classes #104988

merged 2 commits into from
May 31, 2022

Conversation

a14n
Copy link
Contributor

@a14n a14n commented May 30, 2022 •
edited
Loading

Related to dart-lang/linter#3428 : immutable classes without explicit constructor are not catched by prefer_const_constructors_in_immutables. This PR fixes some of them.

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels May 30, 2022
@a14n a14n requested a review from goderbauer May 31, 2022 06:25
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels May 31, 2022
goderbauer
goderbauer approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you!

@a14n a14n merged commit 552c50e into flutter:master May 31, 2022
@a14n a14n deleted the more-const branch May 31, 2022 19:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
2f3204f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
306d545
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
40cca7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
c26b094
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
e8b377a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
ca69732
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
5cf6b23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
07b51b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
a8c451f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
c7bcaa6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
ea52341
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
8f571bd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
552c50e more const immutable classes (flutter/flutter#104988)
e6934ee
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
0e5be22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
076c688
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
2d463af
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
35d5fba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
c291e39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
df5ca66
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
a95f1ec
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
c4b3e05
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
4b3f9a5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
835eef4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
3896ffa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
6f0f16d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
9290cab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
edb525c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
1eaddb3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
490278f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
5719fd4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
39d679b
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@a14n @camsim99
more const immutable classes (flutter#104988)
33d739f 
* more const immutable classes

* more const constructors in dev/ and examples/
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
552c50e67 more const immutable classes (flutter/flutter#104988)
1718ee4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
552c50e more const immutable classes (flutter/flutter#104988)
11ae544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a14n @goderbauer