Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining uses of hashValues in the framework #105046

Merged
merged 1 commit into from
May 31, 2022
Merged

Remove remaining uses of hashValues in the framework #105046

merged 1 commit into from
May 31, 2022

Conversation

jason-simmons
Copy link
Member

@flutter-dashboard flutter-dashboard bot added engine flutter/engine repository. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 31, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

zanderso
zanderso approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Did the autoroller create a roll to this hash that failed? If so, could you link to it in this PR so we can easily look at the list of engine commits?

goderbauer
goderbauer approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons
Copy link
Member Author

This is the engine->framework roll where hashValues was deprecated:
#105038

This was referenced May 31, 2022
Closed
Closed
@fluttergithubbot fluttergithubbot merged commit 116d657 into flutter:master May 31, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
37b743b 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 31, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
43db611 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
500a22d 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
d26033c 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
c5e9bdf 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
3abb39d 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
2245c30 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 1, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
0b9a7ec 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
c6bb07e 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
9394d87 
…er/flutter#105046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
dabc710 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
105fa55 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
3ffa097 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
67bb6f4 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
116d657 Remove remaining uses of hashValues in the framework (flutter…
8096602 
…/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
265396f 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
e634972 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
2d2851f 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
f6d936d 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
c4a18b0 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
b7a2627 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
80b9222 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
80a5602 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
bebef1a 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
b7cd2a2 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
69f5c2e 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
fa9e3ce 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
7a37af5 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
ab8c1da 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
7355d17 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
336db4f 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
a113258 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
c603ba7 
…er/flutter#105046)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@jason-simmons @camsim99
Remove remaining uses of hashValues in the framework (flutter#105046)
20bdf28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
116d6579c Remove remaining uses of hashValues in the framework (flutt…
6ec0788 
…er/flutter#105046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
116d657 Remove remaining uses of hashValues in the framework (flutter…
c1fcd2f 
…/flutter#105046)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jason-simmons @goderbauer @zanderso @fluttergithubbot