Move corrupted zip to a separate handler and ask user #105054

blasten · 2022-05-31T20:05:07Z

Moves the corrupted zip to separate handler
Prompts the user if they would like to delete the $HOME/.gradle directory prior to retrying the build.

camsim99

LGTM! Just one question.

camsim99 · 2022-06-03T17:02:45Z

packages/flutter_tools/lib/src/android/gradle_errors.dart

-        final Directory directory = globals.fs.directory(globals.fs.path.join(homeDir, '.gradle'));
-        ErrorHandlingFileSystem.deleteIfExists(directory, recursive: true);
+      if (homeDir == null) {
+        globals.logger.printStatus("Could not delete .gradle directory because there isn't a HOME env variable");


Out of complete curiosity, how common would it be for someone to have moved it since the home directory is the default? If decently common, would it be reasonable to allow them provide the path to delete it?

I don't think it is common. The user would need to do something different than what Gradle does by default: https://docs.gradle.org/current/userguide/directory_layout.html#dir:gradle_user_home

I'm also not sure if it's possible.- I'm not aware of a GRADLE_HOME variable or similar that would inform Gradle where this directory is.

…ter/flutter#105054)

…r/flutter#105054)

…ter/flutter#105054)

danchengash · 2022-06-25T09:17:31Z

On which Channel is this fix on because am still getting a re-download of gradle with flutter 3.0.2 - stable channel

ziakhan110 · 2022-08-17T10:46:49Z

Still getting this issue

…ter/flutter#105054)

…r/flutter#105054)

kudak3 · 2022-09-08T07:08:46Z

I am still getting this error on flutter 3.0.4

camsim99 · 2022-09-14T23:11:39Z

@Genialngash @ziakhan110 @kudak3 Are any of you receiving the warning "Your .gradle directory under the home directory might be corrupted." before Gradle redownloads?

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 31, 2022

blasten requested review from GaryQian and camsim99 May 31, 2022 20:05

Move corrupted zip to a separate handler and ask user

bb6286e

blasten force-pushed the remove_gradle_removal branch from 0c89547 to bb6286e Compare May 31, 2022 20:17

Remove override

33dcb61

blasten mentioned this pull request May 31, 2022

Allow to configure the behavior of deleting the .gradle folder if there is a connection problem #89959

Closed

Emmanuel Garcia added 2 commits May 31, 2022 13:21

remove import

e86a8a0

Merge branch 'upstream/master' into remove_gradle_removal

3e3dbf2

camsim99 approved these changes Jun 3, 2022

View reviewed changes

blasten added the waiting for tree to go green label Jun 3, 2022

fluttergithubbot merged commit 975e04b into flutter:master Jun 3, 2022

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 975e04ba6d48 (165 revisions) flutter/packages#2197

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

3563b58

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 889a15eb9df6 (167 revisions) flutter/packages#2198

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

ccfb488

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from e8995736bf55 to 889a15eb9df6 (176 revisions) flutter/plugins#5905

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022

975e04b Move corrupted zip to a separate handler and ask user (flutte…

4307cf4

…r/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 2e1ebd83b3f6 (173 revisions) flutter/packages#2202

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

540828c

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 7996527b7db8 (174 revisions) flutter/packages#2203

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

c2a5e96

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 81f89aaf6c56 (175 revisions) flutter/packages#2204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

0defab2

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2205

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

2edcd4f

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2206

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

a8ceff3

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 8294d9e91e39 (183 revisions) flutter/packages#2207

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

259f31b

…ter/flutter#105054)

AlexV525 mentioned this pull request Jun 6, 2022

Don't delete the entire .gradle directory when a build error #92469

Closed

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to 1b2ee411aa13 (190 revisions) flutter/packages#2208

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

3c31ed4

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to c181e450c8df (191 revisions) flutter/packages#2209

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

115125e

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to 712752d2fb18 (192 revisions) flutter/packages#2211

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

3fc2459

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to 67a18250b17e (193 revisions) flutter/packages#2212

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

570507e

…ter/flutter#105054)

engine-flutter-autoroll mentioned this pull request Jun 6, 2022

Roll Flutter from 36fe51524f72 to d5c62438e3e0 (194 revisions) flutter/packages#2213

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

83b3d30

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

d8b6d62

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

1a0b506

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

09d55b0

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

2c352aa

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

125e0f7

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

6447d0a

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

5ba597b

…ter/flutter#105054)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Move corrupted zip to a separate handler and ask user (flutter#105054)

e7acb64

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

975e04ba6 Move corrupted zip to a separate handler and ask user (flut…

45245d9

…ter/flutter#105054)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

975e04b Move corrupted zip to a separate handler and ask user (flutte…

7125f0f

…r/flutter#105054)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move corrupted zip to a separate handler and ask user #105054

Move corrupted zip to a separate handler and ask user #105054

blasten commented May 31, 2022

camsim99 left a comment

camsim99 Jun 3, 2022

blasten Jun 3, 2022

danchengash commented Jun 25, 2022

ziakhan110 commented Aug 17, 2022

kudak3 commented Sep 8, 2022

camsim99 commented Sep 14, 2022

Move corrupted zip to a separate handler and ask user #105054

Move corrupted zip to a separate handler and ask user #105054

Conversation

blasten commented May 31, 2022

camsim99 left a comment

Choose a reason for hiding this comment

camsim99 Jun 3, 2022

Choose a reason for hiding this comment

blasten Jun 3, 2022

Choose a reason for hiding this comment

danchengash commented Jun 25, 2022

ziakhan110 commented Aug 17, 2022

kudak3 commented Sep 8, 2022

camsim99 commented Sep 14, 2022