Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on curly_braces_in_flow_control_structures for developer-facing code #105113

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Turn on curly_braces_in_flow_control_structures for developer-facing code #105113

merged 1 commit into from
Jun 2, 2022

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Jun 1, 2022

  • examples/api
  • packages

Part of #104498

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Jun 1, 2022
@guidezpl guidezpl mentioned this pull request Jun 1, 2022
Open
11 tasks
@guidezpl guidezpl requested a review from goderbauer June 1, 2022 10:52
goderbauer
goderbauer approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

analysis_options.yaml
@@ -98,7 +98,7 @@ linter:
# - conditional_uri_does_not_exist # not yet tested
# - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204
- control_flow_in_finally
# - curly_braces_in_flow_control_structures # not required by flutter style
# - curly_braces_in_flow_control_structures # not required by flutter style, but developer-facing code should have this on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just unify this and turn it on right here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for the issue at hand, so I'll let someone else tackle that. :)

@guidezpl guidezpl merged commit 15aa3bf into flutter:master Jun 2, 2022
@guidezpl guidezpl deleted the curly branch June 2, 2022 09:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
252f533 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
d752747 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
d16ef3e 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
f031386 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
6022736 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
6d8d602 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
914bcc6 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
a9bc2e2 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
15aa3bf turn on curly_braces_in_flow_control_structures for develop…
b87090b 
…-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
85a6961 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
ad3da00 
…op-facing code (flutter/flutter#105113)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
cf18592 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
47dc0a4 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
98deffe 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
d75ba08 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
f16e708 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
b410f7f 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
6ca6416 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
bdb09e1 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
9e0ce53 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
6c185c7 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
6e23a4e 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
cef7ab3 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
a52c2ad 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
308a8c3 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
5ac2cde 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
508c88c 
…op-facing code (flutter/flutter#105113)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@guidezpl @camsim99
turn on curly_braces_in_flow_control_structures for develop-facing …
c932284 
…code (flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
15aa3bfda turn on curly_braces_in_flow_control_structures for devel…
0dbf351 
…op-facing code (flutter/flutter#105113)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
15aa3bf turn on curly_braces_in_flow_control_structures for develop…
f7631e2 
…-facing code (flutter/flutter#105113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guidezpl @goderbauer