Refactor BuildIOSFrameworkCommand with common darwin baseclass #105194

jmagman · 2022-06-02T05:44:38Z

I am working on #104866 and want a common baseclass to share between build ios-framework and build macos-framework. To keep that PR smaller, factor out the common properties and the xcframework logic that will be used by both.

Renamed test build_ios_framework_test to build_darwin_framework_test since the new macOS tests will live in that file, and if I change it now git will track the rename.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-06-02T05:46:28Z

packages/flutter_tools/bin/podhelper.rb

-        s.license          = { :type => 'MIT' }
+        s.summary          = 'A UI toolkit for beautiful and fast apps.'
+        s.homepage         = 'https://flutter.dev'
+        s.license          = { :type => 'BSD' }


This should be BSD https://github.com/CocoaPods/Specs/blob/master/Specs/c/0/4/Flutter/3.0.0/Flutter.podspec.json#L8

jmagman · 2022-06-02T05:47:00Z

packages/flutter_tools/lib/src/commands/build_ios_framework.dart

-      ..addFlag('universal',
-        help: '(deprecated) Produce universal frameworks that include all valid architectures.',
-        hide: !verboseHelp,
-      )
-      ..addFlag('xcframework',


These are both deprecated, don't add to new command that will inherit from BuildFrameworkCommand.

jmagman · 2022-06-02T05:47:20Z

packages/flutter_tools/lib/src/commands/build_ios_framework.dart

  }) : _injectedFlutterVersion = flutterVersion,
       _buildSystem = buildSystem,
       _injectedCache = cache,
       _injectedPlatform = platform,
       super(verboseHelp: verboseHelp) {
    addTreeShakeIconsFlag();
    usesTargetOption();
-    usesFlavorOption();


macOS doesn't support flavors, only add option in subclass BuildIOSFrameworkCommand

jmagman · 2022-06-02T05:56:57Z

packages/flutter_tools/lib/src/commands/build_ios_framework.dart

@@ -410,7 +474,6 @@ end
    Directory iPhoneBuildOutput,
    Directory simulatorBuildOutput,
    Directory modeDirectory,
-    Directory outputDirectory,


This param was unused.

zanderso

LGTM

…ass (flutter/flutter#105194)

flutter/flutter#105194)

…ass (flutter/flutter#105194)

…er#105194)

…ass (flutter/flutter#105194)

flutter/flutter#105194)

Refactor BuildIOSFrameworkCommand with common darwin baseclass

16f9228

jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 2, 2022

jmagman self-assigned this Jun 2, 2022

jmagman commented Jun 2, 2022

View reviewed changes

jmagman requested review from Jasguerrero and christopherfujino June 2, 2022 06:12

zanderso approved these changes Jun 2, 2022

View reviewed changes

jmagman added the waiting for tree to go green label Jun 2, 2022

fluttergithubbot merged commit dffddf0 into flutter:master Jun 2, 2022

jmagman deleted the refactor-ios-fw branch June 2, 2022 17:29

engine-flutter-autoroll mentioned this pull request Jun 2, 2022

Roll Flutter from 36fe51524f72 to dffddf00a22e (139 revisions) flutter/packages#2192

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

6ed18d8

…ass (flutter/flutter#105194)

jmagman mentioned this pull request Jun 2, 2022

Add flutter build macos-framework command #105242

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Jun 2, 2022

Roll Flutter from 36fe51524f72 to 4ec4c249ea5d (140 revisions) flutter/packages#2193

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

9e2264a

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to d4a963165143 (164 revisions) flutter/packages#2196

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

77399a7

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 975e04ba6d48 (165 revisions) flutter/packages#2197

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

ec40e2c

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from 36fe51524f72 to 889a15eb9df6 (167 revisions) flutter/packages#2198

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

780b1b9

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 3, 2022

Roll Flutter from e8995736bf55 to 889a15eb9df6 (176 revisions) flutter/plugins#5905

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022

dffddf0 Refactor BuildIOSFrameworkCommand with common darwin baseclass (

8d5bb53

flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 2e1ebd83b3f6 (173 revisions) flutter/packages#2202

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

8b73fd1

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 7996527b7db8 (174 revisions) flutter/packages#2203

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

ec5a8bf

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 4, 2022

Roll Flutter from 36fe51524f72 to 81f89aaf6c56 (175 revisions) flutter/packages#2204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

e11d75b

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2205

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

81218e8

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 52c47e96a33d (182 revisions) flutter/packages#2206

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

548ac11

…ass (flutter/flutter#105194)

engine-flutter-autoroll mentioned this pull request Jun 5, 2022

Roll Flutter from 36fe51524f72 to 8294d9e91e39 (183 revisions) flutter/packages#2207

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

8cc900a

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

ee0a97e

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

7f7f67b

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

773050b

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

0b32a54

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

d49dc49

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

90470f0

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

73bef3a

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

3818221

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

657d2b0

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

5e156fb

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

a0d6ab9

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

624bd42

…ass (flutter/flutter#105194)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Refactor BuildIOSFrameworkCommand with common darwin baseclass (flutt…

dc8e722

…er#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

dffddf00a Refactor BuildIOSFrameworkCommand with common darwin basecl…

0ad7c19

…ass (flutter/flutter#105194)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

dffddf0 Refactor BuildIOSFrameworkCommand with common darwin baseclass (

b4c1b40

flutter/flutter#105194)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor BuildIOSFrameworkCommand with common darwin baseclass #105194

Refactor BuildIOSFrameworkCommand with common darwin baseclass #105194

jmagman commented Jun 2, 2022 •

edited

jmagman Jun 2, 2022

jmagman Jun 2, 2022 •

edited

jmagman Jun 2, 2022

jmagman Jun 2, 2022

zanderso left a comment

Refactor BuildIOSFrameworkCommand with common darwin baseclass #105194

Refactor BuildIOSFrameworkCommand with common darwin baseclass #105194

Conversation

jmagman commented Jun 2, 2022 • edited

Pre-launch Checklist

jmagman Jun 2, 2022

Choose a reason for hiding this comment

jmagman Jun 2, 2022 • edited

Choose a reason for hiding this comment

jmagman Jun 2, 2022

Choose a reason for hiding this comment

jmagman Jun 2, 2022

Choose a reason for hiding this comment

zanderso left a comment

Choose a reason for hiding this comment

jmagman commented Jun 2, 2022 •

edited

jmagman Jun 2, 2022 •

edited