Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable skipped test for Dart URI logs from DWDS #105274

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Enable skipped test for Dart URI logs from DWDS #105274

merged 1 commit into from
Jun 9, 2022

Conversation

elliette
Copy link
Member

@elliette elliette commented Jun 2, 2022 •
edited
Loading

Enables the test checking for Dart URI warning messages in the logs from DWDS.

Now that DWDS is >13.1.0, this test should be enabled to catch any regressions to #101639.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 2, 2022
christopherfujino
christopherfujino approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@wanchana322 wanchana322 linked an issue Jun 3, 2022 that may be closed by this pull request
1 #105279
Closed
@fluttergithubbot fluttergithubbot merged commit fe57704 into flutter:master Jun 9, 2022
This was referenced Jun 10, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
b408b41 
…utter#105274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe57704 Enable skipped test for Dart URI logs from DWDS (flutter/flut…
0eae6e4 
…ter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
3c59aa6 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe57704 Enable skipped test for Dart URI logs from DWDS (flutter/flut…
8d01d1b 
…ter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
e202397 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe57704 Enable skipped test for Dart URI logs from DWDS (flutter/flut…
303dab1 
…ter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe57704 Enable skipped test for Dart URI logs from DWDS (flutter/flut…
1e17940 
…ter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
2ce12e8 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
1049a4d 
…utter#105274)
This was referenced Jun 11, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
7fddd18 
…utter#105274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
fe57704 Enable skipped test for Dart URI logs from DWDS (flutter/flut…
cee5730 
…ter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
5d4cc7e 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
ef24d96 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
b3accc4 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
d7e25eb 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
01e34cc 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
b073ce1 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
ecb3496 
…utter#105274)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
20e1b46 
…utter#105274)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@elliette @camsim99
Enable skipped test for Dart URI logs from DWDS (flutter#105274)
389dc5d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
fe5770459 Enable skipped test for Dart URI logs from DWDS (flutter/fl…
ff7bce2 
…utter#105274)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
fe57704 Enable skipped test for Dart URI logs from DWDS (flutter/flut…
580fd09 
…ter#105274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1
3 participants
@elliette @christopherfujino @fluttergithubbot