Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated key in _IconButtonM3 #105577

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Remove duplicated key in _IconButtonM3 #105577

merged 1 commit into from
Jun 10, 2022

Conversation

cedvdb
Copy link
Contributor

@cedvdb cedvdb commented Jun 8, 2022 •
edited
Loading

This PR removes the key on _IconButtonM3 as it currently duplicates the parent key. As stated in that issue I'm under the impression that keys should not be reused, since this is not the first time I see this in the flutter repo maybe they are ? In any case, I just removed the duplication in the child widget.

Fixes #105554

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • [n/a] I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 8, 2022
@cedvdb cedvdb force-pushed the fix_105554_duplicated_key branch from 34e811c to 9b1a0bc Compare June 8, 2022 16:38
@cedvdb cedvdb force-pushed the fix_105554_duplicated_key branch from 9b1a0bc to aa17460 Compare June 8, 2022 16:42
darrenaustin
darrenaustin approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. This looks reasonable to me. I don't think we are using the key on the internal _IconButtonM3, so I don't think this will cause in issues.

LGTM

QuncCccccc
QuncCccccc approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the fix!

@fluttergithubbot fluttergithubbot merged commit feec13a into flutter:master Jun 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
4d288c4 
)
This was referenced Jun 11, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
c499219 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
feec13a Remove duplicated key in _IconButtonM3 (flutter/flutter#105577)
62f90c4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
cc7b832 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
8cf639c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
4f9ee17 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
ebfe158 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
9b29f43 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
372eab8 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
5ed37fa 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
6a17170 
)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@cedvdb @camsim99
Remove duplicated key in _IconButtonM3 (flutter#105577)
e962471
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
feec13a16 Remove duplicated key in _IconButtonM3 (flutter/flutter#105577
362952e 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
feec13a Remove duplicated key in _IconButtonM3 (flutter/flutter#105577)
4e9ef1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenaustin darrenaustin darrenaustin approved these changes

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_IconButtonM3 reusing key
5 participants
@cedvdb @darrenaustin @QuncCccccc @HansMuller @fluttergithubbot