Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextFormField docs: added proper type with GlobalKey; replaced "we" #105605

Merged
merged 2 commits into from
Jun 16, 2022
Merged

TextFormField docs: added proper type with GlobalKey; replaced "we" #105605

merged 2 commits into from
Jun 16, 2022

Conversation

EnduringBeta
Copy link
Contributor

2 small doc changes for TextFormField. See issue for more context.

#105603

Also, I'd like to point out that the link to the Contributor Guide below goes to the Tree Hygiene overview. Should it be this? https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 8, 2022
@EnduringBeta
Copy link
Contributor Author

EnduringBeta commented Jun 8, 2022 •
edited
Loading

I'm not sure how to test that the doc link still works fine. Maybe it needs to be one of these:

  • [GlobalKey]<FormFieldState>
  • [GlobalKey]<[FormFieldState]>

I'd also understand if I'm mistaken on this entirely.

@EnduringBeta EnduringBeta changed the title added proper type with GlobalKey; replaced "we" TextFormField docs: added proper type with GlobalKey; replaced "we" Jun 8, 2022
@HansMuller HansMuller requested a review from justinmc June 9, 2022 16:29
HansMuller
HansMuller approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@EnduringBeta @gspencergoog
Update packages/flutter/lib/src/material/text_form_field.dart
092e08f 
fixed broken link syntax in docs with separate parenthetical

Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
gspencergoog
gspencergoog approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@HansMuller HansMuller merged commit 695cfa4 into flutter:master Jun 16, 2022
@EnduringBeta EnduringBeta deleted the text-form-field-doc-tweaks branch June 16, 2022 16:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 16, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
531e3b5 
…d "we" (flutter/flutter#105605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
695cfa436 TextFormField docs: added proper type with GlobalKey; repla…
54d2425 
…ced "we" (flutter/flutter#105605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
695cfa436 TextFormField docs: added proper type with GlobalKey; repla…
6bab74e 
…ced "we" (flutter/flutter#105605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2022
@engine-flutter-autoroll
695cfa436 TextFormField docs: added proper type with GlobalKey; repla…
84d1bfb 
…ced "we" (flutter/flutter#105605)
@HansMuller HansMuller mentioned this pull request Jun 23, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@EnduringBeta @camsim99
TextFormField docs: added proper type with GlobalKey; replaced "we" (f…
da8f549 
…lutter#105605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
695cfa436 TextFormField docs: added proper type with GlobalKey; repla…
1a75029 
…ced "we" (flutter/flutter#105605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
695cfa4 TextFormField docs: added proper type with GlobalKey; replace…
2d2c0c1 
…d "we" (flutter/flutter#105605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

@justinmc justinmc Awaiting requested review from justinmc

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EnduringBeta @HansMuller @gspencergoog