New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue with Hero Animations and BoxScrollViews in Scaffolds #105654
Fixed issue with Hero Animations and BoxScrollViews in Scaffolds #105654
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
62b2e9a
to
67adf0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request needs tests. See https://github.com/flutter/flutter/wiki/Tree-hygiene#tldr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. I feel the documentation could be a bit more specific about what kind of inherited widgets developers should pay attention to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/// if the [Hero] subtree changes appearance based on an [InheritedWidget] (such | ||
/// as [MediaQuery] or [Theme]), then the hero animation may have discontinuity | ||
/// at the start or the end of the animation because route A and route B provides | ||
/// different such [InheritedWidget]s. Consider providing a custom [flightShuttleBuilder] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this Consider providing a custom [flightShuttleBuilder] to ensure smooth transitions
redundant with the last sentence?
Fixed an issue where a jump would happen with Hero animations on mobile when the Hero child was a BoxScrollView and the destination page had a Scaffold with different layout (difference in AppBar, etc).
#99084
Before:
https://user-images.githubusercontent.com/16466991/172736468-d81b7e5a-8bb7-4627-bac6-2632b1e89a74.mov
After:
https://user-images.githubusercontent.com/16466991/172736486-93f08372-e8a0-4d12-b8a1-06ee791cc015.mov
Pre-launch Checklist
///
).