-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard, Web] Map from "Esc" to the Escape key #106133
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you! |
Failures: {Instance of 'FailureDetail'} |
* Impl * Fix build * Add test
This PR fixes #106062 and adds the following entries to the Web key mapping:
"Esc"
to physical keyesc
."Esc"
to logical keyesc
.The change to
PhysicalKeyEntry
is a bit tricky, since it only allows onechromeName
. I didn't want to changechromeName
to a list of string and cause hundreds of lines of changes inphysical_key_data.json
, so I added a new fieldotherWebNames
.The test is co-authored with @egramond from 58fa575#diff-ac9c378fae8af8f4ffb68fad0b56e14f9f15ab797a0e7271a3690317a4df9c59.
All mapping changes will also be applied to the engine in a separate PR.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.