Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the setPubRootDirectory tests #106197

Merged
merged 14 commits into from
Jun 22, 2022
Merged

Refactoring the setPubRootDirectory tests #106197

merged 14 commits into from
Jun 22, 2022

Conversation

CoderDake
Copy link
Contributor

This is a small refactor to the specs that test setPubRootDirectories in the widget_inspector. These changes to the setPubRootTests will make the upcoming PR for #105730 a bit clearer, since the pubRoot tests will be modified to accommodate the new interactions.

In preparation for #105730

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@CoderDake CoderDake requested a review from jacob314 June 17, 2022 14:28
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 17, 2022
@CoderDake CoderDake changed the title Pub root test prep Refactoring the setPubRootDirectory Tests Jun 17, 2022
@CoderDake CoderDake changed the title Refactoring the setPubRootDirectory Tests Refactoring the setPubRootDirectory tests Jun 17, 2022
@HansMuller HansMuller added f: inspector Part of widget inspector in framework. and removed framework flutter/packages/flutter repository. See also f: labels. labels Jun 17, 2022
jacob314
jacob314 reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like good test cleanup refactoring overall. A few small comments on how to make it cleaner.

jacob314
jacob314 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
with dartfmt nit.

@CoderDake CoderDake marked this pull request as ready for review June 21, 2022 17:53
@CoderDake CoderDake merged commit 8ff6911 into flutter:master Jun 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 23, 2022
@engine-flutter-autoroll
8ff6911 Refactoring the setPubRootDirectory tests (flutter/flutter#10…
91c3f9e 
…6197)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2022
@engine-flutter-autoroll
8ff691178 Refactoring the setPubRootDirectory tests (flutter/flutter#…
af4967b 
…106197)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2022
@engine-flutter-autoroll
8ff691178 Refactoring the setPubRootDirectory tests (flutter/flutter#…
0dd1b26 
…106197)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@CoderDake @camsim99
Refactoring the setPubRootDirectory tests (flutter#106197)
ecc5626
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
8ff691178 Refactoring the setPubRootDirectory tests (flutter/flutter#…
c488de4 
…106197)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
8ff6911 Refactoring the setPubRootDirectory tests (flutter/flutter#10…
13d328b 
…6197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob314 jacob314 jacob314 approved these changes

Assignees
No one assigned
Labels
f: inspector Part of widget inspector in framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CoderDake @jacob314 @HansMuller