New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ListTile
theme shape in a drawer
#106343
Fix ListTile
theme shape in a drawer
#106343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TahaTesser thanks for the fix. The approach you use here would make the ListTile handle its theme data differently than all the other widgets. I have a suggestion below that I think would be a better fix for this.
5626500
to
c4c52de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change, and I think we are good to go. Thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thx!
fixes #106303
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.