Improve SnackBar error message when shown during build #106658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
Piinks
approved these changes
Jun 27, 2022
Piinks
changed the title
|
Marked WIP so the bot will not merge accidentally. |
|
Internal tests all passed, it looks like there is a merge conflict though, can you resolve? |
Piinks
changed the title
bleroux
force-pushed
the
improve_snackbar_shown_during_build_error_message
branch
from
28f00f6
to
12b60aa
Compare
bleroux
force-pushed
the
improve_snackbar_shown_during_build_error_message
branch
from
12b60aa
to
66cb5a7
Compare
Piinks
added
waiting for tree to go green
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 1, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR catches the generic error thrown when calling
ScaffoldMessenger.showSnackBar()during build and throws an error with a more intuitive message.Related Issue
Fixes #66789
Tests
Adds 1 test.