Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll Flutter Engine from b9547182c38b to caec3e305a23 (1 revision)" #106958

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Jul 1, 2022

Reverts #106926

For #106957

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine repository. See also e: labels. label Jul 1, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. waiting for tree to go green autosubmit Merge PR when tree becomes green via auto submit App labels Jul 1, 2022
@zanderso
Copy link
Member Author

zanderso commented Jul 1, 2022

@godofredoc what labels do I need to add to trigger a tip-of-tree revert?

@fluttergithubbot fluttergithubbot merged commit 1e14993 into master Jul 1, 2022
@fluttergithubbot fluttergithubbot deleted the revert-106926-flutter-engine-flutter-autoroll-6ade78b6-e119-4e25-b437-01bd698d22be-1656646466 branch July 1, 2022 15:09
@zanderso
Copy link
Member Author

zanderso commented Jul 1, 2022

Looks like the collection I picked worked.

@godofredoc
Copy link
Contributor

Looks like the collection I picked worked.

Let me confirm if the "land on red to fix tree breakage" is implemented in autosubmit.

\cc @keyonghan @ricardoamador

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine repository. See also e: labels. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants