[flutter roll] Revert "Reland "Clipping if only one character text overflows (#99146… #106964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r#99146)" (flutter#102130)" This reverts commit 3f43d9f.
flutter-dashboard
bot
added
a: text input
|
cc @xu-baolin |
|
It looks like this is making text in chips fade out at the right edge of the chip even though there appears to be enough room for the text. This doesn't look correct and needs more investigation. While it's getting investigated, a revert SGTM. |
justinmc
reviewed
Jul 1, 2022
There was a problem hiding this comment.
LGTM 👍
I agree with @goderbauer's assessment. @xu-baolin There is some visible TextOverflow.fade happening now that wasn't happening before the PR.
justinmc
approved these changes
Jul 1, 2022
|
Thanks everyone for analyzing and inspecting! This helps a lot with the roll |
XilaiZhang
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 2, 2022
… (#99146)" (#102130)" (flutter/flutter#106964)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2022
…ws (#99146)" (#102130)" (flutter/flutter#106964)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…r#99146)" (flutter#102130)" (flutter#106964) This reverts commit 3f43d9f.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
…ws (#99146)" (#102130)" (flutter/flutter#106964)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
… (#99146)" (#102130)" (flutter/flutter#106964)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…)" (#102130)"
This reverts commit 3f43d9f.
This breaks tests such as //third_party/fuchsia_gui_tools/fuchsia_devtools:tests_test_iquery_iquery_tree_pane_test.host in https://scuba.corp.google.com/#/report/0bec7a50-21cc-40fd-a3a2-2c00ad01d913?groupBy=Golden+Location&pageSize=25&pageIndex=0&selected_node=0bec7a50-21cc-40fd-a3a2-2c00ad01d913&status=2 , where the scubas become the form of a gradient color.