Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputDecorator: Switch hint to Opacity instead of AnimatedOpacity #107156

Merged
merged 1 commit into from Jul 8, 2022
Merged

InputDecorator: Switch hint to Opacity instead of AnimatedOpacity #107156

merged 1 commit into from Jul 8, 2022

Conversation

markusaksli-nc
Copy link
Member

@markusaksli-nc markusaksli-nc commented Jul 6, 2022 •
edited

The AnimatedOpacity transition doesn't match native components on at least Android and web. M3 doesn't include Placeholder text anymore and I can't find anything saying that it was animated. The original complaint also stated that the transition from hint to input text can be disorienting.

This PR switches the hint to Opacity, making the opacity transition instant.

Fixes #20283

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 6, 2022
@HansMuller HansMuller mentioned this pull request Jul 6, 2022
Closed
HansMuller
HansMuller approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit 255b71f into flutter:master Jul 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
255b71f Switch hint text to Opacity instead of AnimatedOpacity (flutt…
aa308d3 
…er/flutter#107156)
This was referenced Jul 9, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
255b71f19 Switch hint text to Opacity instead of AnimatedOpacity (flu…
dbc5e77 
…tter/flutter#107156)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
255b71f Switch hint text to Opacity instead of AnimatedOpacity (flutt…
8b53905 
…er/flutter#107156)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
255b71f Switch hint text to Opacity instead of AnimatedOpacity (flutt…
6c7468e 
…er/flutter#107156)
@markusaksli-nc markusaksli-nc deleted the hint-opacity branch July 11, 2022 13:27
CaseyHillers added a commit that referenced this pull request Jul 11, 2022
@CaseyHillers
Revert "Switch hint text to Opacity instead of AnimatedOpacity (#107156…
0ed1c14 
…)"

This reverts commit 255b71f.
@CaseyHillers CaseyHillers mentioned this pull request Jul 11, 2022
Merged
@markusaksli-nc
Copy link
Member Author

markusaksli-nc commented Jul 14, 2022 •
edited

@HansMuller I saw this was reverted in #107406 due to some breaking internal tests. Is there something I can fix?

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@markusaksli-nc @camsim99
Switch hint text to Opacity instead of AnimatedOpacity (flutter#107156)
eedaed0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
255b71f19 Switch hint text to Opacity instead of AnimatedOpacity (flu…
115d006 
…tter/flutter#107156)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
255b71f Switch hint text to Opacity instead of AnimatedOpacity (flutt…
0cf085e 
…er/flutter#107156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hint text should disappear instead of fade out
2 participants
@markusaksli-nc @HansMuller