Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove listeners from pending images when clearing cache #107276

Merged
merged 2 commits into from Jul 8, 2022
Merged

Remove listeners from pending images when clearing cache #107276

merged 2 commits into from Jul 8, 2022

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 8, 2022

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 8, 2022
@dnfield
Copy link
Contributor Author

dnfield commented Jul 8, 2022

This changes some existing behavior:

  • If you clear the image cache and it had a pending image that gets completed after the clear, before this patch the pending image would have ended up in the cache anyway - now it does not.

I think this change is desirable.

darrenaustin
darrenaustin approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not that familiar with the image cache, but this LGTM.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2022
@auto-submit auto-submit bot merged commit 37de496 into flutter:master Jul 8, 2022
This was referenced Jul 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
37de496 Remove listeners from pending images when clearing cache (flu…
3bb933a 
…tter/flutter#107276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
37de4960a Remove listeners from pending images when clearing cache (f…
1e4e718 
…lutter/flutter#107276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
37de496 Remove listeners from pending images when clearing cache (flu…
3f155a7 
…tter/flutter#107276)
@dnfield dnfield deleted the live_image_clear branch July 8, 2022 16:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
37de496 Remove listeners from pending images when clearing cache (flu…
e2c6c0a 
…tter/flutter#107276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 8, 2022
@engine-flutter-autoroll
37de496 Remove listeners from pending images when clearing cache (flu…
487af9d 
…tter/flutter#107276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
37de496 Remove listeners from pending images when clearing cache (flu…
d516d2c 
…tter/flutter#107276)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 9, 2022
@engine-flutter-autoroll
37de496 Remove listeners from pending images when clearing cache (flu…
2ac7323 
…tter/flutter#107276)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@dnfield @camsim99
Remove listeners from pending images when clearing cache (flutter#107276
01eeb94 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
37de4960a Remove listeners from pending images when clearing cache (f…
378a625 
…lutter/flutter#107276)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
37de496 Remove listeners from pending images when clearing cache (flu…
d0540f5 
…tter/flutter#107276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenaustin darrenaustin darrenaustin approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_LiveImages leak if they are pending when the image cache is cleared.
2 participants
@dnfield @darrenaustin