remove unused members in executable libs

[a14n]

Related to dart-lang/linter#685 and dart-lang/linter#2395

[goderbauer]

LGTM!

Thank you! This looks like a nice cleanup!

[goderbauer]

nit: keep this blank line.

[auto-submit]

Try again when the tree status has been applied to this PR.

[goderbauer]

@a14n Does this PR clean up unused members across the entire flutter/flutter repository and we only had them in the dev directory? Or did you limit the clean-up to only the dev directory in the first place? (Just curious to know if there is more in our code base...)

[a14n]

I ran the lint rule on the entire flutter/flutter repo. There are only 2 reports that I didn't touch. Not really false-positive but strange code that I don't really understand:

• flutter/dev/integration_tests/non_nullable/lib/main.dart

  Line 7 in 018dc1d

  String? unused;

• flutter/dev/integration_tests/web/lib/null_safe_main.dart

  Line 7 in 018dc1d

  String? x;

[goderbauer]

Thanks. Those two look like they are on purpose (I wish we would have added a comment to explain that when we first introduced them).

I am a little surprised it didn't find any of the stuff I found in #104561 with a different tool. Do you have any idea why those didn't show up?

[auto-submit]

• The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.

[a14n]

I am a little surprised it didn't find any of the stuff I found in #104561 with a different tool. Do you have any idea why those didn't show up?

After a quick random check it looks like all those lib are not executable libraries (containing a main or a @pragma('vm:entry-point')). I guess the tool you used check usage in the whole /src but this kind of analysis is too heavy to run as a lint (on every changes).

[goderbauer]

That makes sense. Thanks for checking!