Increase app minimum supported macOS version from 10.11 to 10.13 #107689

jmagman · 2022-07-15T00:52:58Z

Increase minimum Flutter app target macOS version from 10.11 to macOS 10.13 High Sierra and higher.

Change templates to MACOSX_DEPLOYMENT_TARGET and Podfile platform :osx to 10.13.
Add migrator for these settings for existing apps.
Run migrator on all example apps and integration tests.

This does not include upping the plugin templates, as those need to wait until the 10.13 framework reaches stable so new plugins can actually build with stable flutter created apps, see #89695 for details.

Similar iOS migration at #101963
Fixes #107688
Fixes #57805
Part of #107492.
Will unblock flutter/buildroot#588

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan · 2022-07-15T17:32:00Z

As an added bonus, this will "fix" #57805 :)

jmagman · 2022-07-15T18:01:47Z

@zanderso any timing concerns with this? Or is this okay to merge?

jmagman · 2022-07-15T18:03:49Z

packages/flutter_tools/test/general.shard/macos/macos_project_migration_test.dart

-  testWithoutContext('skips migrating script with embed', () {
-    const String contents = r'''
+  group('remove link and embed migration', () {
+    late TestUsage testUsage;


Added the group so this part is a whitespace only change.

jmagman · 2022-07-15T18:04:01Z

packages/flutter_tools/test/general.shard/macos/macos_project_migration_test.dart

-      'migration fails with leftover FlutterMacOS.framework reference', () {
-    xcodeProjectInfoFile.writeAsStringSync('''
-				33D1A10522148B93bogus /* FlutterMacOS.framework in Bundle Framework */,
+  group('update deployment target version', () {


These are the new tests.

zanderso

No timing concerns.

jmagman · 2022-07-15T18:12:39Z

Google testing is stalled due to omg/55671, I was told to merge manually 🙂

…10.13 (flutter/flutter#107689)

cbracken

Thanks!

…10.13 (flutter/flutter#107689)

…tter#107689)

Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates. Includes: * Update migration for macOS 10.11 apps to upgrade to 10.14 * Adds migration for macOS 10.13 apps to upgrade to 10.14 * Apply migration to all examples, and integration tests This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel. Issue: #114445 See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4 See previous patch: #107689

…#114713) Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates. Includes: * Update migration for macOS 10.11 apps to upgrade to 10.14 * Adds migration for macOS 10.13 apps to upgrade to 10.14 * Apply migration to all examples, and integration tests This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel. Issue: flutter#114445 See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4 See previous patch: flutter#107689

Bumps the minimum supported macOS version to prepare for Flutter's global minimum change (flutter/flutter#107689) and to allow for adding `ASWebAuthenticationSupport` later

Increase app minimum supported macOS version from 10.11 to 10.13

9c8f99b

jmagman added tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Jul 15, 2022

jmagman self-assigned this Jul 15, 2022

flutter-dashboard bot added d: examples Sample code and demos platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Jul 15, 2022

dnfield approved these changes Jul 15, 2022

View reviewed changes

jmagman requested review from cbracken and zanderso July 15, 2022 18:01

jmagman commented Jul 15, 2022

View reviewed changes

zanderso approved these changes Jul 15, 2022

View reviewed changes

jmagman merged commit c4975d9 into flutter:master Jul 15, 2022

jmagman deleted the mac-min-version branch July 15, 2022 18:12

This was referenced Jul 15, 2022

Increase plugin template minimum supported macOS version from 10.11 to 10.13, match Flutter SDK constraint #107739

Open

Update all plugins minimum from macOS 10.11 to 10.13 #107740

Open

stuartmorgan mentioned this pull request Jul 15, 2022

[ci] Manual roll of Flutter to c4975d9be0e2f3ca6279ea4ba77b23cc549e2926 flutter/plugins#6108

Merged

This was referenced Jul 15, 2022

Update macOS minimum version documentation to 10.13 flutter/website#7371

Closed

☂️ Increase minimum support macOS version from 10.11 to 10.13 #107741

Open

Bump the min-deployment-target on macOS desktop targets to 10.13 #107492

Closed

engine-flutter-autoroll mentioned this pull request Jul 16, 2022

Roll Flutter from bbec650b64bc to 4f9528293f54 (21 revisions) flutter/packages#2327

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

646c284

…10.13 (flutter/flutter#107689)

cbracken reviewed Jul 18, 2022

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

9a3a285

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

716ef7c

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

9059a35

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

af727d6

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

ac05ab0

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

c985595

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

397f5ad

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

ce2c5a3

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

8b95db9

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

deb1444

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

265e48d

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

5b9962d

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

6e0b84f

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

a7a2593

…10.13 (flutter/flutter#107689)

jmagman mentioned this pull request Jul 26, 2022

Set Xcode build script phases to always run #108331

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

597419f

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

6c46464

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

b66bb4c

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

fdb2c34

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

c9ff980

…10.13 (flutter/flutter#107689)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

c4975d9be Increase app minimum supported macOS version from 10.11 to …

c7460fa

…10.13 (flutter/flutter#107689)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Increase app minimum supported macOS version from 10.11 to 10.13 (flu…

78670e7

…tter#107689)

huycozy mentioned this pull request Aug 24, 2022

[MacOS ] English characters and numbers are garbled on MacOS #110133

Closed

cbracken mentioned this pull request Nov 4, 2022

Increase minimum supported macOS version from 10.13 to 10.14 #114713

Merged

8 tasks

darshankawar mentioned this pull request Dec 2, 2022

MacOS font rending issue on 2015 macbooks #116402

Closed

FeodorFitsner mentioned this pull request Dec 29, 2022

fletd issue ‘dyld: Symbol not found: _utimensat’ on macOS 10.12.6 flet-dev/flet#779

Closed

frankmorgner mentioned this pull request Feb 23, 2023

update ax_pthread to version 31 (autoconf-archive-2022.02.11) OpenSC/OpenSC#2717

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase app minimum supported macOS version from 10.11 to 10.13 #107689

Increase app minimum supported macOS version from 10.11 to 10.13 #107689

jmagman commented Jul 15, 2022 •

edited

Loading

stuartmorgan commented Jul 15, 2022

jmagman commented Jul 15, 2022

jmagman Jul 15, 2022

jmagman Jul 15, 2022

zanderso left a comment

jmagman commented Jul 15, 2022

cbracken left a comment

Increase app minimum supported macOS version from 10.11 to 10.13 #107689

Increase app minimum supported macOS version from 10.11 to 10.13 #107689

Conversation

jmagman commented Jul 15, 2022 • edited Loading

Pre-launch Checklist

stuartmorgan commented Jul 15, 2022

jmagman commented Jul 15, 2022

jmagman Jul 15, 2022

Choose a reason for hiding this comment

jmagman Jul 15, 2022

Choose a reason for hiding this comment

zanderso left a comment

Choose a reason for hiding this comment

jmagman commented Jul 15, 2022

cbracken left a comment

Choose a reason for hiding this comment

jmagman commented Jul 15, 2022 •

edited

Loading