make ModalBottomSheetRoute public

[The-Redhat]

Currently it is not possible to use the ModalBottomSheetRoute in named routes (f.e. in the auto_route package) because it is private. In contrast the DialogRoute is public and therefore can be used.

This PR makes the ModalBottomSheetRoute public.

Related Issues

• Create a ModalBottomSheetPage #87352
• [go_router] [navigator 2.0] declarative version of showModalBottomSheet is missing #104193

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[The-Redhat]

Hey @stuartmorgan I'm not sure whom to tag / ask for review. Can you please help me out.

[goderbauer]

fly-by comment: @The-Redhat can you please take a look at the failing analyzer check and fix the reported issue? Also, please address the issue of missing tests (see comment by flutter-dashboard) before asking for review.

[The-Redhat]

Hey @HansMuller and @chunhtai can you please guide me on how a test for this change can look like.
Thank you for your help and have a great weekend.

[chunhtai]

To write a test, you can use normal Navigator.push to open the modal bottom sheet and verify it opens as expected. You also want to verify the parameter works too.

[The-Redhat]

everything fixed. @chunhtai can you please review the mr

[The-Redhat]

Hey @chunhtai is there something I have to do on my end?

[The-Redhat]

@chunhtai everything is fixed now :)

[auto-submit]

auto label is removed for flutter/flutter, pr: 108112, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

[auto-submit]

auto label is removed for flutter/flutter, pr: 108112, due to Validations Fail.

[chunhtai]

cc @goderbauer for a secondary review

[The-Redhat]

@goderbauer do you have some time to check this PR?

[gliitterpuke]

would love to see this! eta until merge?

[The-Redhat]

Hey @goderbauer I took care of your review comments

[ryzizub]

Would love to see this merged 🚀

[goderbauer]

LGTM

[jamesblasco]

This PR breaks the https://pub.dev/packages/modal_bottom_sheet package as it contains the same class. From the public available information this package is used in 12k open source projects hosted in github.

It would be great if we can come up with a solution before it gets out of hand in the packages repo:
jamesblasco/modal_bottom_sheet#284