Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable jank metrics for web #109356

Merged
merged 2 commits into from Aug 11, 2022
Merged

Disable jank metrics for web #109356

merged 2 commits into from Aug 11, 2022

Conversation

Jasguerrero
Copy link
Contributor

@Jasguerrero Jasguerrero commented Aug 11, 2022 •
edited

Fixes: #107495

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 11, 2022
@Jasguerrero Jasguerrero marked this pull request as ready for review August 11, 2022 04:34
christopherfujino
christopherfujino approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Jasguerrero Jasguerrero added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2022
@auto-submit auto-submit bot merged commit edd4668 into flutter:master Aug 11, 2022
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
2f5e577
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
bde1d1e
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
65f794a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
84ddbb0
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
28f3e19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
7dfc021
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
4aacd7d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
d972b3a
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
a5daf24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
735f818
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
fd66bde
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
c31a2a1
This was referenced Aug 13, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
5630efb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
1f3f98f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
a39aeeb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
93593a4
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
1d7814f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
a1313cc
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
448d949
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
b8ab64a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
013a2ca
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
b86dfc2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
429f2ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
4dc1173
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
5441da9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
8cf5156
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
29d2281
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
9cbf720
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd466811 Disable jank metrics for web (flutter/flutter#109356)
bc8de41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
edd4668 Disable jank metrics for web (flutter/flutter#109356)
7a0686d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flutter_tools] _flutter.renderFrameWithRasterStats: (-32601) Unknown method
2 participants
@Jasguerrero @christopherfujino